Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add write permissions to PR labelling action #25356

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

corivera
Copy link
Member

@corivera corivera commented Feb 20, 2024

Opening this PR to see if the permissions issue is fixed with the PR labelling action.

Edit: Label action succeeded, so we can actually merge this change

@corivera
Copy link
Member Author

@kisantia can I merge this change in directly, or should I make a PR for it in main first?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7980817189

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 41.757%

Totals Coverage Status
Change from base Build 7978218924: 0.0%
Covered Lines: 30827
Relevant Lines: 69082

💛 - Coveralls

@kisantia
Copy link
Contributor

@kisantia can I merge this change in directly, or should I make a PR for it in main first?

can you change the target branch for this PR to main, then port it to the release branch? So that this will be fixed for the next releases too

@corivera corivera changed the base branch from release/1.48 to main February 20, 2024 23:41
@corivera
Copy link
Member Author

@kisantia can I merge this change in directly, or should I make a PR for it in main first?

can you change the target branch for this PR to main, then port it to the release branch? So that this will be fixed for the next releases too

Done

@corivera
Copy link
Member Author

I'll skip the validation checks, since this only applied to the one action

@corivera corivera merged commit fc3861d into main Feb 21, 2024
10 of 14 checks passed
@corivera corivera deleted the corivera/permissionTest branch February 21, 2024 00:16
ssreerama added a commit that referenced this pull request Feb 22, 2024
* Add null checks for undefined include/exclude patterns in search view (#25336) (#25354)

* Add write permissions to PR labelling action (#25356) (#25359)

* Updating STS new version (#25357)

* vbump sql projects after insiders release to 1.4.2

* vbump sql projects after insiders release to 1.4.2

---------

Co-authored-by: Cory Rivera <corivera@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants