Remove/comment out connection title generation from all areas. #23873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of commenting, I'd recommend removing code to keep source clean. |
|
code has been cleaned up now |
|
would be nice if you could share some screenshots for comparison. |
cheenamalhotra
approved these changes
Jul 14, 2023
+1, and preferably with comparison shots of current stable |
|
@Charles-Gagnon @alanrenmsft Screenshots have been uploaded showing comparison |
|
Could you include some screenshots of dev without a connection name as well? (but still with the "duplicate" connections) |
|
@Charles-Gagnon Added screenshots to the end of the original post. |
|
Proceeding to merge. |
smartguest
added a commit
that referenced
this pull request
Jul 18, 2023
kburtram
pushed a commit
that referenced
this pull request
Jul 19, 2023
* Port request of title generation removal * added fix to CMS * added updated mainthread * Revert "added updated mainthread" This reverts commit a580655. * Revert "added fix to CMS" This reverts commit 2b8c24f. * Revert "Port request of title generation removal" This reverts commit e6a2302. * Remove/comment out connection title generation from all areas. (#23873) --------- Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
This was referenced Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes and comments out the title generation function from all areas but retains support for advanced connection options.
Companion PR for STS: microsoft/sqltoolsservice#2145
Comparison Screenshots
Object Explorer:
Stable (These two connections are treated as one due to same target database):
Dev:
Recent Connections:
Stable (Only two, as the first one has a different target database technically):
Dev:
Dashboard:
Stable:
Dev (header is the same):
Notebook:
Stable:
Dev:
Server Status:
Stable:
Dev:
Query Editor:
Stable:
Dev:
Table Designer:
Stable:
Dev:
OE without connection name:
Stable:
Dev:
Recent Connections without connection name:
Stable:
Dev:
