Add limit on the file size that can be opened with Open XEL feature #23841

SakshiS-harma · 2023-07-12T22:59:52Z

This PR works on fixing #23806.

For files within 100MB, no notification is posted.

For files from 100MB-1GB, a notification is posted:

For files more than 1GB, an error is thrown and file is not loaded:

src/sql/workbench/services/profiler/browser/profilerService.ts

… for large files

SakshiS-harma · 2023-07-13T21:49:56Z

Just to add context here, here are the numbers from testing the open XEL feature:

Immediately opens for 200KB file.
~ 2secs for 8MB file.
~ 15-18secs for a 250MB file.
~ 36-38secs for a 600MB file.
~ 1min for a 900MB file.
~ 3mins for 0.99GB file.

src/sql/workbench/services/profiler/browser/profilerService.ts

Charles-Gagnon · 2023-07-13T21:53:59Z

src/sql/workbench/services/profiler/browser/profilerService.ts

+					this._notificationService.error(nls.localize('FileTooLarge', "The file is too large to open in profiler. The profiler can open files that are less than 1GB."));
+					return false;
+				} else if (fileSize > fileOpenWarningSize) {
+					this._notificationService.info(nls.localize('LargeFileWait', "Loading the file might take a moment, because the file is large."));


What's the experience like now? Is there a loading spinner already? This notification seems unnecessary if that's the case. Generally we don't try to guess whether an operation is going to take a long time - the closest we may do to something like that is show a progress notification after a short delay saying something like "Opening file..." to show that it's working in the background.

Its a blank profiler screen for now. No loading spinner. But I can take that as a follow up workitem.

That's unfortunate - alright then taking this for now and creating an issue to follow up post-release with for improving this seems fine. Thanks for verifying!

…23841) * Add limit on the file size that can be opened with Open XEL feature * Add limit on the file size that can be opened and post a notification for large files * Update wording * Use FileService interface instead of fs to fix layering rules

…23841) (#23876) * Add limit on the file size that can be opened with Open XEL feature * Add limit on the file size that can be opened and post a notification for large files * Update wording * Use FileService interface instead of fs to fix layering rules

SakshiS-harma · 2023-07-14T19:51:55Z

Created following work items as discussed:
#23883 Add loading indicator when opening XEL file in profiler
#23885 Profiler should minimize UI disruption while loading XEL file

Add limit on the file size that can be opened with Open XEL feature

1203639

SakshiS-harma requested review from kburtram, Benjin and kisantia July 12, 2023 22:59

kisantia reviewed Jul 12, 2023

View reviewed changes