Fix license txt #949
Open
Fix license txt #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Oguz Bastemur <ogbastem@microsoft.com> Co-authored-by: Christopher J. Brody <chris.brody@gmail.com>
|
|
This was referenced Jul 27, 2018
janpio
pushed a commit
to apache/cordova-windows
that referenced
this pull request
Sep 2, 2018
…ies/Default.rd.xml (#286) ### Original issue <https://issues.apache.org/jira/browse/CB-14225> ### Platforms affected Windows ### What does this PR do? - Fix sample Namespace Serialize attribute in `template/Properties/Default.rd.xml`, according to `Default.rd.xml` in C# UWP project generated by Visual Studio 2017 I also raised <microsoft/Windows-universal-samples#950> to apply a similar fix there. Also related: - #284 - fix license text & add link to `template/Properties/Default.rd.xml` (as reported in <https://issues.apache.org/jira/browse/CB-14224>) - <microsoft/Windows-universal-samples#949> - fix license txt (related to but not part of #284) ### What testing has been done on this change? - Visual inspection - check diff ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. - ~~Added automated test coverage as appropriate for this change.~~
oldnewthing
force-pushed
the
master
branch
6 times, most recently
from
2239d7f
to
9bf6501
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be the same as LICENSE.txt in ChakraCore:
All rights reserved.@obastemur is marked as the primary author of the changes from ChakraCore since he made the last addition.