Update C# Share Target example to allow resourceMap images to show up in web view. #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edge starting from RS2 is sharing images in a resourceMap.
oldnewthing
reviewed
Jun 11, 2017
| await reader.LoadAsync((uint)stream.Size); | ||
| byte[] byteArray = new byte[stream.Size]; | ||
| reader.ReadBytes(byteArray); | ||
| String base64String = "<img src ='data:image/gif;base64," + Convert.ToBase64String(byteArray) + "'"; |
There was a problem hiding this comment.
Should use stream.ContentType
oldnewthing
reviewed
Jun 11, 2017
| foreach (KeyValuePair<string, RandomAccessStreamReference> item in this.sharedResourceMap) | ||
| { | ||
| var stream = await item.Value.OpenReadAsync(); | ||
| if (!stream.ContentType.Contains("image/")) |
oldnewthing
reviewed
Jun 11, 2017
| byte[] byteArray = new byte[stream.Size]; | ||
| reader.ReadBytes(byteArray); | ||
| String base64String = "<img src ='data:image/gif;base64," + Convert.ToBase64String(byteArray) + "'"; | ||
| String replaceTarget = "<img src=" + item.Key; |
There was a problem hiding this comment.
Could the key be quoted in the original HTML? Does this need to be case-sensitive? What if there are other attributes between the img and the src?
oldnewthing
reviewed
Jun 11, 2017
| String base64String = "<img src ='data:image/gif;base64," + Convert.ToBase64String(byteArray) + "'"; | ||
| String replaceTarget = "<img src=" + item.Key; | ||
|
|
||
| htmlFragment = htmlFragment.Replace(replaceTarget, base64String); |
There was a problem hiding this comment.
Would it be better to use a stream resolver? Then you won't run into trouble if the image is large and exceeds the maximum length of a data: URI.
There was a problem hiding this comment.
Haven't used a stream resolver before, hmm any pointers?
Going to have a look at the XamlWebView example
There was a problem hiding this comment.
Not entirely sure that was what you want.
I also have an alternate solution to this if this wasn't what you wanted.
if (!String.IsNullOrEmpty(htmlFragment))
{
if (this.sharedResourceMap.Count > 0)
{
foreach (KeyValuePair<string, RandomAccessStreamReference> item in this.sharedResourceMap)
{
try
{
using (var resourceStream = await item.Value.OpenReadAsync())
{
var tempFile = await folder.CreateFileAsync(Path.GetFileName(item.Key), CreationCollisionOption.OpenIfExists);
using (var stream = await tempFile.OpenStreamForWriteAsync())
{
await resourceStream.AsStreamForRead().CopyToAsync(stream);
}
htmlFragment = htmlFragment.Replace(item.Key, tempFile.Name);
}
}
catch (Exception ex)
{
htmlFragment = htmlFragment.Replace(item.Key, @"ms-appx-web:///Assets/error.png");
}
}
}
AddContentValue("HTML: ");
ShareWebView.Visibility = Visibility.Visible;
var html = "<html><body>" + htmlFragment + "</body></html>";
var file = await folder.CreateFileAsync("html.html", CreationCollisionOption.OpenIfExists);
await FileIO.WriteTextAsync(file, html);
ShareWebView.Navigate(new Uri("ms-appdata:///temp/folder/html.html"));
}
ChrisGuzak
reviewed
Oct 8, 2017
| { | ||
| try | ||
| { | ||
| Uri localUri = new Uri("ms-appdata:///temp/folder/" + URIPath); |
There was a problem hiding this comment.
minor things
- rename URIPath to uriPath (camelCase for parameters)
- use var for localUri and StorageFile (type name is repeated)
oldnewthing
force-pushed
the
master
branch
6 times, most recently
from
2239d7f
to
9bf6501
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update C# Share Target example to allow resourceMap images to show up in web view.
In RS2, Edge has a new feature 'Saved Tabs' that is sharing images out as resourceMap