Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

WIP - updated some dependencies #1024

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Conversation

pjlittle
Copy link
Collaborator

@pjlittle pjlittle commented Nov 3, 2020

  • Updated to most recent version of react-scripts (4.0)
    • May still be an issue w/ referencing a specific version of react-router typings (5.0)
  • Update TypeScript
  • Fixed compilation errors
  • Migrated from tslint --> eslint
    • disabled a TON of warnings/errors (1000s)
  • Nows runs on Node 12.x on OSX

TODO:

  • Need to test this on Windows
  • Need to update pipelines to reference Node LTS/erbium (12.x)

NOTES:

  • deprecated react-appinsights@3.0.0: This package is no longer supported. Please use @microsoft/applicationinsights-react-js instead

@sonarcloud
Copy link

sonarcloud bot commented Nov 4, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fishcharlie
Copy link

@pjlittle @wbreza

What is the status on this? With another Electron upgrade I think this should fix #1065 as well (https://www.electronjs.org/blog/apple-silicon/). Maybe also we can include another Electron update in here? Based on the TODO list in the original comment (and looking at the changes) it looks like the pipelines have been updated, but testing on Windows is the only thing that needs to be done?

I'd be happy to help dedicate some time to helping with this. Really want to get #1065 fixed. But there are some indications that this project has been abandoned. So don't want to sink a bunch of time into a project that is dead.

cc/ @tbarlow12 (since it looks like you have a lot of contributions to this project)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants