Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contextually type array elements using index signatures #58288

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Contextually type array elements using index signatures #58288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6712b3
Contextually type array elements using index signatures
Andarist Apr 22, 2024
45a26c0
Merge remote-tracking branch 'origin/main' into fix/contextual-elemen…
Andarist May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/compiler/checker.ts
View file
Open in desktop
Expand Up @@ -30708,8 +30708,9 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
}
// If element index is known and a contextual property with that name exists, return it. Otherwise return the
// iterated or element type of the contextual type.
return (!firstSpreadIndex || index < firstSpreadIndex) && getTypeOfPropertyOfContextualType(t, "" + index as __String) ||
getIteratedTypeOrElementType(IterationUse.Element, t, undefinedType, /*errorNode*/ undefined, /*checkAssignability*/ false);
return (firstSpreadIndex === undefined || index < firstSpreadIndex) && getTypeOfPropertyOfContextualType(t, "" + index as __String) ||
getIteratedTypeOrElementType(IterationUse.Element, t, undefinedType, /*errorNode*/ undefined, /*checkAssignability*/ false) ||
getApplicableIndexInfo(t, numberType)?.type;
}, /*noReductions*/ true);
}

Expand Down
46 changes: 46 additions & 0 deletions tests/baselines/reference/spreadsAndContextualArrayLikeTypes1.errors.txt
View file
Open in desktop
@@ -0,0 +1,46 @@
spreadsAndContextualArrayLikeTypes1.ts(40,32): error TS7006: Parameter 'a' implicitly has an 'any' type.


==== spreadsAndContextualArrayLikeTypes1.ts (1 errors) ====
// https://github.com/microsoft/TypeScript/issues/58286

type MyType<T extends unknown> = {
myKey: T;
myFunction: (arg1: T) => void;
};

declare const generate: () => Array<MyType<string>>;

declare const arrayLikeInferenceFunction: <T extends unknown>(
arr: ArrayLike<T>,
) => T[];

arrayLikeInferenceFunction([
{ myKey: "123", myFunction: (value1) => {} },
...generate(),
{ myKey: "456", myFunction: (value2) => {} },
]);

arrayLikeInferenceFunction([
{ myKey: "123", myFunction: (value1) => {} },
{ myKey: "456", myFunction: (value2) => {} },
...generate(),
]);

arrayLikeInferenceFunction([
...generate(),
{ myKey: "123", myFunction: (value1) => {} },
{ myKey: "456", myFunction: (value2) => {} },
]);

declare function numericProperties(weirdo: {
"0": (a: 0) => void;
"1": (a: 1) => void;
"2": (a: 2) => void;
}): void;

const tuple1 = [() => {}, () => {}] as const;

numericProperties([...tuple1, (a) => {}]);
~
!!! error TS7006: Parameter 'a' implicitly has an 'any' type.
118 changes: 118 additions & 0 deletions tests/baselines/reference/spreadsAndContextualArrayLikeTypes1.symbols
View file
Open in desktop
@@ -0,0 +1,118 @@
//// [tests/cases/compiler/spreadsAndContextualArrayLikeTypes1.ts] ////

=== spreadsAndContextualArrayLikeTypes1.ts ===
// https://github.com/microsoft/TypeScript/issues/58286

type MyType<T extends unknown> = {
>MyType : Symbol(MyType, Decl(spreadsAndContextualArrayLikeTypes1.ts, 0, 0))
>T : Symbol(T, Decl(spreadsAndContextualArrayLikeTypes1.ts, 2, 12))

myKey: T;
>myKey : Symbol(myKey, Decl(spreadsAndContextualArrayLikeTypes1.ts, 2, 34))
>T : Symbol(T, Decl(spreadsAndContextualArrayLikeTypes1.ts, 2, 12))

myFunction: (arg1: T) => void;
>myFunction : Symbol(myFunction, Decl(spreadsAndContextualArrayLikeTypes1.ts, 3, 11))
>arg1 : Symbol(arg1, Decl(spreadsAndContextualArrayLikeTypes1.ts, 4, 15))
>T : Symbol(T, Decl(spreadsAndContextualArrayLikeTypes1.ts, 2, 12))

};

declare const generate: () => Array<MyType<string>>;
>generate : Symbol(generate, Decl(spreadsAndContextualArrayLikeTypes1.ts, 7, 13))
>Array : Symbol(Array, Decl(lib.es5.d.ts, --, --), Decl(lib.es5.d.ts, --, --))
>MyType : Symbol(MyType, Decl(spreadsAndContextualArrayLikeTypes1.ts, 0, 0))

declare const arrayLikeInferenceFunction: <T extends unknown>(
>arrayLikeInferenceFunction : Symbol(arrayLikeInferenceFunction, Decl(spreadsAndContextualArrayLikeTypes1.ts, 9, 13))
>T : Symbol(T, Decl(spreadsAndContextualArrayLikeTypes1.ts, 9, 43))

arr: ArrayLike<T>,
>arr : Symbol(arr, Decl(spreadsAndContextualArrayLikeTypes1.ts, 9, 62))
>ArrayLike : Symbol(ArrayLike, Decl(lib.es5.d.ts, --, --))
>T : Symbol(T, Decl(spreadsAndContextualArrayLikeTypes1.ts, 9, 43))

) => T[];
>T : Symbol(T, Decl(spreadsAndContextualArrayLikeTypes1.ts, 9, 43))

arrayLikeInferenceFunction([
>arrayLikeInferenceFunction : Symbol(arrayLikeInferenceFunction, Decl(spreadsAndContextualArrayLikeTypes1.ts, 9, 13))

{ myKey: "123", myFunction: (value1) => {} },
>myKey : Symbol(myKey, Decl(spreadsAndContextualArrayLikeTypes1.ts, 14, 3))
>myFunction : Symbol(myFunction, Decl(spreadsAndContextualArrayLikeTypes1.ts, 14, 17))
>value1 : Symbol(value1, Decl(spreadsAndContextualArrayLikeTypes1.ts, 14, 31))

...generate(),
>generate : Symbol(generate, Decl(spreadsAndContextualArrayLikeTypes1.ts, 7, 13))

{ myKey: "456", myFunction: (value2) => {} },
>myKey : Symbol(myKey, Decl(spreadsAndContextualArrayLikeTypes1.ts, 16, 3))
>myFunction : Symbol(myFunction, Decl(spreadsAndContextualArrayLikeTypes1.ts, 16, 17))
>value2 : Symbol(value2, Decl(spreadsAndContextualArrayLikeTypes1.ts, 16, 31))

]);

arrayLikeInferenceFunction([
>arrayLikeInferenceFunction : Symbol(arrayLikeInferenceFunction, Decl(spreadsAndContextualArrayLikeTypes1.ts, 9, 13))

{ myKey: "123", myFunction: (value1) => {} },
>myKey : Symbol(myKey, Decl(spreadsAndContextualArrayLikeTypes1.ts, 20, 3))
>myFunction : Symbol(myFunction, Decl(spreadsAndContextualArrayLikeTypes1.ts, 20, 17))
>value1 : Symbol(value1, Decl(spreadsAndContextualArrayLikeTypes1.ts, 20, 31))

{ myKey: "456", myFunction: (value2) => {} },
>myKey : Symbol(myKey, Decl(spreadsAndContextualArrayLikeTypes1.ts, 21, 3))
>myFunction : Symbol(myFunction, Decl(spreadsAndContextualArrayLikeTypes1.ts, 21, 17))
>value2 : Symbol(value2, Decl(spreadsAndContextualArrayLikeTypes1.ts, 21, 31))

...generate(),
>generate : Symbol(generate, Decl(spreadsAndContextualArrayLikeTypes1.ts, 7, 13))

]);

arrayLikeInferenceFunction([
>arrayLikeInferenceFunction : Symbol(arrayLikeInferenceFunction, Decl(spreadsAndContextualArrayLikeTypes1.ts, 9, 13))

...generate(),
>generate : Symbol(generate, Decl(spreadsAndContextualArrayLikeTypes1.ts, 7, 13))

{ myKey: "123", myFunction: (value1) => {} },
>myKey : Symbol(myKey, Decl(spreadsAndContextualArrayLikeTypes1.ts, 27, 3))
>myFunction : Symbol(myFunction, Decl(spreadsAndContextualArrayLikeTypes1.ts, 27, 17))
>value1 : Symbol(value1, Decl(spreadsAndContextualArrayLikeTypes1.ts, 27, 31))

{ myKey: "456", myFunction: (value2) => {} },
>myKey : Symbol(myKey, Decl(spreadsAndContextualArrayLikeTypes1.ts, 28, 3))
>myFunction : Symbol(myFunction, Decl(spreadsAndContextualArrayLikeTypes1.ts, 28, 17))
>value2 : Symbol(value2, Decl(spreadsAndContextualArrayLikeTypes1.ts, 28, 31))

]);

declare function numericProperties(weirdo: {
>numericProperties : Symbol(numericProperties, Decl(spreadsAndContextualArrayLikeTypes1.ts, 29, 3))
>weirdo : Symbol(weirdo, Decl(spreadsAndContextualArrayLikeTypes1.ts, 31, 35))

"0": (a: 0) => void;
>"0" : Symbol("0", Decl(spreadsAndContextualArrayLikeTypes1.ts, 31, 44))
>a : Symbol(a, Decl(spreadsAndContextualArrayLikeTypes1.ts, 32, 8))

"1": (a: 1) => void;
>"1" : Symbol("1", Decl(spreadsAndContextualArrayLikeTypes1.ts, 32, 22))
>a : Symbol(a, Decl(spreadsAndContextualArrayLikeTypes1.ts, 33, 8))

"2": (a: 2) => void;
>"2" : Symbol("2", Decl(spreadsAndContextualArrayLikeTypes1.ts, 33, 22))
>a : Symbol(a, Decl(spreadsAndContextualArrayLikeTypes1.ts, 34, 8))

}): void;

const tuple1 = [() => {}, () => {}] as const;
>tuple1 : Symbol(tuple1, Decl(spreadsAndContextualArrayLikeTypes1.ts, 37, 5))
>const : Symbol(const)

numericProperties([...tuple1, (a) => {}]);
>numericProperties : Symbol(numericProperties, Decl(spreadsAndContextualArrayLikeTypes1.ts, 29, 3))
>tuple1 : Symbol(tuple1, Decl(spreadsAndContextualArrayLikeTypes1.ts, 37, 5))
>a : Symbol(a, Decl(spreadsAndContextualArrayLikeTypes1.ts, 39, 31))