Reverse mapped types with intersection constraint #55811

jfet97 · 2023-09-21T11:56:57Z

TLDR

This PR enhances reverse mapped types capabilities providing users with the ability to enable EPC (Excess Property Checking) on type parameters inference sites.

Background

This PR has come up trying to find a way to solve some problems discussed in #55645 and #55644, which are a simplification of what's going on in this PR from XState. In those cases the usual type parameters inference behaviour is not enough, mainly because it disables EPC (Excess Property Checking).

FIxes #55927

Idea

Reverse mapped types are a powerful tool. Currently TypeScript is able to reverse three kind of mapped types:

a homomorphic mapped type { [P in keyof T]: X }
a mapped type { [P in K]: X }, where K is a type parameter
a mapped type with an union constraint, as long as the union contains one of the constraints of the previous cases

This PR adds a fourth case: a mapped type with an intersection constraint, as long as the intersection contains one of the constraints of the previous cases.

While the union constraint could be seen as a way to force the presence of some properties, the intersection one could be seen as a way to prevent the presence of extra properties.

Examples

Example N. 1

Here the type parameter T is now inferred, by reversing the mapped type, as { bar: 1; baz: "a"; record: { a: number; b: number } }, instead of falling back to its constraint Foo. The properties of the parameter s are constrained to be exactly the ones already declared in Foo, so EPC comes into play if the argument contains extra properties:

interface Foo {
  bar: number;
  baz: string;
  record: Record<any, any>;
}

// the intersection constraint on `K` is `keyof T & keyof Foo`
declare function useFoo<T extends Foo>(s: { [K in keyof T & keyof Foo]: T[K] } ): T

useFoo({ 
  bar: 1,
  baz: 'a',
  record: { a: 1, b: 2 },
  extra: 123, // <-- EPC error
})

In this way you get both inference and EPC check!
Note that the extra property is stripped away from T because it wouldn't survive the action of the mapped type anyway.

Example N. 2

In the following example, inspired from #12936, is the type parameter U the one that gets inferred by reversing the mapped type. It is inferred as { x: 1; y: "y"; record: { a: number; b: number } } instead of falling back to its constraint. As before, no extra properties are allowed so we get an EPC error on z that will always be stripped away from the inferred type:

// the intersection constraint on `K` is `keyof U & keyof T`
const checkType = <T>() => <U extends T>(value: { [K in keyof U & keyof T]: U[K] }) => value;

const checked = checkType<{x: number, y: string, record: Record<any, any> }>()({
  x: 1,
  y: "y",
  record: { a: 1, b: 2 },
  z: "z", // <-- EPC error
});

Tests

Two tests files have been added:

reverseMappedTypeIntersectionConstraint, in which the main capabilities brought by this PR have been tested, although I must admit I don't think there are enough test cases
reverseMappedTypeLimitedConstraint, in which the stripping behaviour on the inferred type parameters has been written down, but it is somehow subsumed by the previous test and for this reason it might be deleted altogether

A note on EPC

What's good about this PR is the fact that it lets the user enable EPC on type parameters without fundamentally change how TS treats type parameters inference. It's just a nice side effect of enhancing reverse mapped types' capabilities.

Remarks

This PR may help with some cases presented in #12936 as well.

#55794 could help improving what happens when a const type parameter is used, because there are some inconsistencies with readonly modifiers.

Acknowledgements

Huge thanks to @Andarist for always having my back 😄.

typescript-bot · 2023-09-21T11:57:02Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

jfet97 · 2023-09-21T11:58:00Z

@microsoft-github-policy-service agree

…aint

sandersn · 2023-09-29T22:29:05Z

@jfet97 can you open a new bug with your proposal where we can discuss it? For complex issues like this the PR itself is usually pretty short, but if it sits around for long the code gets stale.

jfet97 · 2023-09-30T08:13:47Z

Done 😄, it's #55927 @sandersn

…aint

weswigham · 2023-10-03T20:37:44Z

This looks pretty good, but since it's definitely pretty high on the break risk scale (since it's intentionally adding new errors), let me run the extended tests and say that we'll probably want to merge this after we cut the 5.3 rc, so it can be in the nightly for awhile.

@typescript-bot test this
@typescript-bot run dt
@typescript-bot test top100
@typescript-bot perf test this

typescript-bot · 2023-10-03T20:37:47Z

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at d3d7a45. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-10-03T20:37:47Z

Heya @weswigham, I've started to run the regular perf test suite on this PR at d3d7a45. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-10-03T20:37:48Z

Heya @weswigham, I've started to run the diff-based top-repos suite on this PR at d3d7a45. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-10-03T20:58:00Z

@weswigham
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,085k (± 0.02%)}	_{295,069k (± 0.01%)}	_~	_295,021k	_295,133k	_{p=0.630 n=6}
_{Parse Time}	_{2.64s (± 0.39%)}	_{2.64s (± 0.46%)}	_~	_2.62s	_2.65s	_{p=1.000 n=6}
_{Bind Time}	_{0.84s (± 0.99%)}	_{0.84s (± 1.43%)}	_~	_0.83s	_0.86s	_{p=0.863 n=6}
_{Check Time}	_{8.05s (± 0.35%)}	_{8.06s (± 0.33%)}	_~	_8.02s	_8.09s	_{p=0.809 n=6}
_{Emit Time}	_{7.05s (± 0.29%)}	_{7.04s (± 0.24%)}	_~	_7.02s	_7.07s	_{p=0.220 n=6}
_{Total Time}	_{18.59s (± 0.15%)}	_{18.58s (± 0.21%)}	_~	_18.51s	_18.63s	_{p=0.808 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{194,557k (± 1.53%)}	_{192,636k (± 1.58%)}	_~	_190,642k	_196,618k	_{p=0.336 n=6}
_{Parse Time}	_{1.35s (± 1.15%)}	_{1.35s (± 1.28%)}	_~	_1.33s	_1.38s	_{p=0.865 n=6}
_{Bind Time}	_{0.73s (± 0.00%)}	_{0.73s (± 0.56%)}	_~	_0.73s	_0.74s	_{p=0.405 n=6}
_{Check Time}	_{9.18s (± 1.00%)}	_{9.18s (± 0.80%)}	_~	_9.12s	_9.28s	_{p=0.744 n=6}
_{Emit Time}	_{2.63s (± 0.66%)}	_{2.65s (± 0.62%)}	_~	_2.63s	_2.67s	_{p=0.324 n=6}
_{Total Time}	_{13.89s (± 0.62%)}	_{13.90s (± 0.44%)}	_~	_13.83s	_13.98s	_{p=0.568 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,294k (± 0.00%)}	_{347,302k (± 0.00%)}	_~	_347,279k	_347,316k	_{p=0.296 n=6}
_{Parse Time}	_{2.46s (± 0.33%)}	_{2.46s (± 0.61%)}	_~	_2.45s	_2.49s	_{p=0.738 n=6}
_{Bind Time}	_{0.94s (± 0.43%)}	_{0.94s (± 0.00%)}	_~	_0.94s	_0.94s	_{p=0.405 n=6}
_{Check Time}	_{6.87s (± 0.18%)}	_{6.91s (± 0.72%)}	_~	_6.87s	_6.99s	_{p=0.073 n=6}
_{Emit Time}	_{4.01s (± 0.37%)}	_{4.02s (± 0.37%)}	_~	_4.00s	_4.04s	_{p=0.243 n=6}
_{Total Time}	_{14.29s (± 0.25%)}	_{14.34s (± 0.30%)}	_~	_14.29s	_14.40s	_{p=0.092 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,536k (± 0.00%)}	_{302,540k (± 0.01%)}	_~	_302,521k	_302,574k	_{p=0.422 n=6}
_{Parse Time}	_{2.01s (± 0.73%)}	_{2.00s (± 0.98%)}	_~	_1.97s	_2.02s	_{p=0.871 n=6}
_{Bind Time}	_{1.00s (± 1.36%)}	_{1.00s (± 0.98%)}	_~	_0.99s	_1.02s	_{p=1.000 n=6}
_{Check Time}	_{6.27s (± 0.57%)}	_{6.24s (± 0.27%)}	_~	_6.22s	_6.26s	_{p=0.168 n=6}
_{Emit Time}	_{3.56s (± 0.63%)}	_{3.57s (± 0.33%)}	_~	_3.56s	_3.59s	_{p=0.289 n=6}
_{Total Time}	_{12.84s (± 0.23%)}	_{12.81s (± 0.22%)}	_~	_12.79s	_12.85s	_{p=0.370 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,506k (± 0.00%)}	_{470,507k (± 0.00%)}	_~	_470,480k	_470,532k	_{p=1.000 n=6}
_{Parse Time}	_{2.57s (± 0.47%)}	_{2.57s (± 0.49%)}	_~	_2.55s	_2.59s	_{p=0.738 n=6}
_{Bind Time}	_{1.00s (± 1.09%)}	_{0.99s (± 0.52%)}	_~	_0.99s	_1.00s	_{p=0.247 n=6}
_{Check Time}	_{16.65s (± 0.55%)}	_{16.66s (± 0.27%)}	_~	_16.58s	_16.70s	_{p=1.000 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.22s (± 0.43%)}	_{20.22s (± 0.17%)}	_~	_20.16s	_20.25s	_{p=0.936 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,618k (± 0.01%)}	_{512,597k (± 0.01%)}	_~	_512,543k	_512,714k	_{p=0.575 n=6}
_{Parse Time}	_{3.27s (± 0.23%)}	_{3.27s (± 0.23%)}	_~	_3.26s	_3.28s	_{p=1.000 n=6}
_{Bind Time}	_{1.55s (± 0.00%)}	_{1.55s (± 0.26%)}	_~	_1.54s	_1.55s	_{p=0.405 n=6}
_{Check Time}	_{2.87s (± 0.26%)}	_{2.88s (± 1.18%)}	_~	_2.84s	_2.93s	_{p=0.871 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{7.76s (± 0.15%)}	_{7.76s (± 0.38%)}	_~	_7.73s	_7.81s	_{p=0.871 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,377ms (± 1.53%)}	_{2,359ms (± 1.20%)}	_~	_2,327ms	_2,396ms	_{p=0.335 n=6}
_{Req 2 - geterr}	_{5,325ms (± 1.26%)}	_{5,368ms (± 1.64%)}	_~	_5,257ms	_5,469ms	_{p=0.471 n=6}
_{Req 3 - references}	_{333ms (± 1.39%)}	_{330ms (± 1.58%)}	_~	_325ms	_338ms	_{p=0.293 n=6}
_{Req 4 - navto}	_{278ms (± 0.58%)}	_{277ms (± 0.94%)}	_~	_273ms	_280ms	_{p=0.677 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{77ms (± 5.98%)}	_{83ms (±10.41%)}	_~	_74ms	_91ms	_{p=0.303 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,457ms (± 1.27%)}	_{2,473ms (± 1.43%)}	_~	_2,426ms	_2,515ms	_{p=0.471 n=6}
_{Req 2 - geterr}	_{4,127ms (± 1.89%)}	_{4,137ms (± 2.03%)}	_~	_4,050ms	_4,218ms	_{p=0.471 n=6}
_{Req 3 - references}	_{337ms (± 1.55%)}	_{336ms (± 1.14%)}	_~	_332ms	_343ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{284ms (± 0.35%)}	_{284ms (± 0.18%)}	_~	_283ms	_284ms	_{p=0.931 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{79ms (± 7.50%)}	_{78ms (± 6.27%)}	_~	_76ms	_88ms	_{p=0.654 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,594ms (± 0.15%)}	_{2,600ms (± 0.42%)}	_~	_2,582ms	_2,614ms	_{p=0.170 n=6}
_{Req 2 - geterr}	_{1,689ms (± 2.28%)}	_{1,683ms (± 1.74%)}	_~	_1,651ms	_1,719ms	_{p=0.689 n=6}
_{Req 3 - references}	_{108ms (± 4.69%)}	_{120ms (± 9.45%)}	_~	_104ms	_128ms	_{p=0.170 n=6}
_{Req 4 - navto}	_{360ms (± 0.43%)}	_{360ms (± 0.94%)}	_~	_354ms	_364ms	_{p=0.803 n=6}
_{Req 5 - completionInfo count}	_{2,071 (± 0.00%)}	_{2,071 (± 0.00%)}	_~	_2,071	_2,071	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{306ms (± 1.74%)}	_{307ms (± 1.14%)}	_~	_303ms	_312ms	_{p=0.688 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{152.25ms (± 0.18%)}	_{152.30ms (± 0.17%)}	_~	_151.30ms	_154.36ms	_{p=0.094 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.75ms (± 0.16%)}	_{227.72ms (± 0.17%)}	_~	_226.45ms	_234.14ms	_{p=0.053 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.45ms (± 0.21%)}	_{228.54ms (± 0.21%)}	_{+0.09ms (+ 0.04%)}	_226.99ms	_243.49ms	_{p=0.012 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.82ms (± 0.17%)}	_{228.82ms (± 0.16%)}	_~	_227.09ms	_231.45ms	_{p=0.905 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-10-03T21:54:28Z

@weswigham Here are the results of running the top-repos suite comparing main and refs/pull/55811/merge:

Everything looks good!

typescript-bot · 2023-10-03T22:09:11Z

Hey @weswigham, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

jfet97 · 2023-10-04T05:50:50Z

@weswigham thanks for your review, I'm glad you liked it!

To be honest I didn't expect any particular problems because:

reverse mapped types are sort of a niche/advanced feature
if you try to reverse a mapped type with an intersection constraint now the result is pretty useless, in the sense that it doesn't infer the type parameter, so I find it hard to believe that it ever occurred to someone to try 😂

I believe the tests not finding any errors supports my opinion, but there is no rush to add this feature of course. I'm just sharing my thoughts.

RyanCavanaugh · 2023-10-04T20:16:24Z

src/compiler/checker.ts

@@ -13523,14 +13523,34 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
        return instantiateType(instantiable, createTypeMapper([type.indexType, type.objectType], [getNumberLiteralType(0), createTupleType([replacement])]));
    }

+    function getLimitedConstraint(type: ReverseMappedType) {


I'd really like a comment explaining a "limited constraint" is, maybe with an example or two. Otherwise LGTM

Comments have been added. I hope it's clearer now.

…aint

Andarist · 2023-10-23T17:05:15Z

@jakebailey would you be so kind to create a TS playground for this one? :)

jakebailey · 2023-10-23T17:23:44Z

@typescript-bot pack this

typescript-bot · 2023-10-23T17:23:50Z

Heya @jakebailey, I've started to run the tarball bundle task on this PR at 21fae9e. You can monitor the build here.

typescript-bot · 2023-10-23T17:25:52Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/158307/artifacts?artifactName=tgz&fileId=A516E71E34A0566287DB0253279348F1DBC0344BC8D24046ACDBDC7EE31BF6CD02&fileName=/typescript-5.3.0-insiders.20231023.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.3.0-pr-55811-15".;

…aint

jfet97 · 2023-12-01T11:35:06Z

Another example can be found on this playground by @Andarist , to be compared with the 5.3.2 one. The latter fails to infer completely in the first scenario.

jfet97 and others added 5 commits September 21, 2023 10:40

support intersection constraint, add test

4a5dfd0

Reverse limiting constraint

83964d3

enhance getLimitedConstraint, add test case

1df3661

enhance tests

702c002

update test

a48fd7c

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Sep 21, 2023

Merge branch 'main' into reverse-mapped-type-with-intersection-constr…

21a0eb0

…aint

sandersn added this to Not started in PR Backlog Sep 29, 2023

sandersn moved this from Not started to Waiting on author in PR Backlog Sep 29, 2023

sandersn self-assigned this Sep 29, 2023

sandersn requested review from sandersn and weswigham September 29, 2023 22:29

jfet97 mentioned this pull request Sep 30, 2023

Support for reverse mapped types with intersection constraint #55927

Closed

5 tasks

Merge branch 'main' into reverse-mapped-type-with-intersection-constr…

d3d7a45

…aint

jfet97 changed the title ~~Reverse mapped type with intersection constraint~~ Reverse mapped types with intersection constraint Sep 30, 2023

weswigham added this to the TypeScript 5.4.0 milestone Oct 3, 2023

sandersn moved this from Waiting on author to Needs merge in PR Backlog Oct 4, 2023

weswigham approved these changes Oct 4, 2023

View reviewed changes

RyanCavanaugh reviewed Oct 4, 2023

View reviewed changes

jfet97 added 3 commits October 5, 2023 10:03

Merge branch 'main' into reverse-mapped-type-with-intersection-constr…

7cad0bd

…aint

add comments

394a636

enhance comment

4c6b623

typescript-bot added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Oct 5, 2023

enhance comment

21fae9e

Merge branch 'main' into reverse-mapped-type-with-intersection-constr…

3200fc0

…aint

sandersn merged commit eb2046d into microsoft:main Nov 30, 2023
19 checks passed

PR Backlog automation moved this from Needs merge to Done Nov 30, 2023

Andarist mentioned this pull request Dec 8, 2023

Show implied options in --showConfig #56701

Merged

Andarist mentioned this pull request Dec 31, 2023

Reverse mapped type fails to be inferred with constraint that is a union containing an intersection #56910

Open

Andarist deleted the reverse-mapped-type-with-intersection-constraint branch January 4, 2024 20:36

jfet97 mentioned this pull request Jan 5, 2024

Infer unknown at value positions of objects inferred from keyof T #55547

Open

Andarist mentioned this pull request Jan 10, 2024

Fixes reverse mapped type members limiting constraint #56911

Open

This was referenced Jan 11, 2024

TypeScript 5.4 Iteration Plan #56948

Open

Instantiate conditional types within contextual type instantiation when inference candidates are available #48838

Draft

Andarist mentioned this pull request Apr 2, 2024

Support satisfies as a constraint on a function's generic type parameter #58031

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reverse mapped types with intersection constraint #55811

Reverse mapped types with intersection constraint #55811

jfet97 commented Sep 21, 2023 •

edited

typescript-bot commented Sep 21, 2023

jfet97 commented Sep 21, 2023

sandersn commented Sep 29, 2023

jfet97 commented Sep 30, 2023

weswigham commented Oct 3, 2023

typescript-bot commented Oct 3, 2023 •

edited

typescript-bot commented Oct 3, 2023 •

edited

typescript-bot commented Oct 3, 2023 •

edited

typescript-bot commented Oct 3, 2023

Compiler

tsserver

Startup

typescript-bot commented Oct 3, 2023

typescript-bot commented Oct 3, 2023

jfet97 commented Oct 4, 2023 •

edited

RyanCavanaugh Oct 4, 2023

jfet97 Oct 5, 2023 •

edited

Andarist commented Oct 23, 2023 •

edited

jakebailey commented Oct 23, 2023

typescript-bot commented Oct 23, 2023 •

edited

typescript-bot commented Oct 23, 2023 •

edited

jfet97 commented Dec 1, 2023

Reverse mapped types with intersection constraint #55811

Reverse mapped types with intersection constraint #55811

Conversation

jfet97 commented Sep 21, 2023 • edited

TLDR

Background

Idea

Examples

Example N. 1

Example N. 2

Tests

A note on EPC

Remarks

Acknowledgements

typescript-bot commented Sep 21, 2023

jfet97 commented Sep 21, 2023

sandersn commented Sep 29, 2023

jfet97 commented Sep 30, 2023

weswigham commented Oct 3, 2023

typescript-bot commented Oct 3, 2023 • edited

typescript-bot commented Oct 3, 2023 • edited

typescript-bot commented Oct 3, 2023 • edited

typescript-bot commented Oct 3, 2023

Compiler

tsserver

Startup

typescript-bot commented Oct 3, 2023

typescript-bot commented Oct 3, 2023

jfet97 commented Oct 4, 2023 • edited

RyanCavanaugh Oct 4, 2023

Choose a reason for hiding this comment

jfet97 Oct 5, 2023 • edited

Choose a reason for hiding this comment

Andarist commented Oct 23, 2023 • edited

jakebailey commented Oct 23, 2023

typescript-bot commented Oct 23, 2023 • edited

typescript-bot commented Oct 23, 2023 • edited

jfet97 commented Dec 1, 2023

jfet97 commented Sep 21, 2023 •

edited

typescript-bot commented Oct 3, 2023 •

edited

typescript-bot commented Oct 3, 2023 •

edited

typescript-bot commented Oct 3, 2023 •

edited

jfet97 commented Oct 4, 2023 •

edited

jfet97 Oct 5, 2023 •

edited

Andarist commented Oct 23, 2023 •

edited

typescript-bot commented Oct 23, 2023 •

edited

typescript-bot commented Oct 23, 2023 •

edited