Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow visibility on constructors #4174

Closed
wants to merge 14 commits into from
Closed

Allow visibility on constructors #4174

wants to merge 14 commits into from

Commits on Aug 5, 2015

  1. Fixes issue #2341

    @AbubakerB
    AbubakerB committed Aug 5, 2015
    Configuration menu
    Copy the full SHA
    708f423 View commit details
    Browse the repository at this point in the history

  2. Add tests for issue #2341

    @AbubakerB
    AbubakerB committed Aug 5, 2015
    Configuration menu
    Copy the full SHA
    9dfa9c7 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2015

  1. Accept baselines

    @AbubakerB
    AbubakerB committed Aug 6, 2015
    Configuration menu
    Copy the full SHA
    6d01766 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2015

  1. Add check on construct signature and relevant test cases.

    @AbubakerB
    AbubakerB committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    7105a41 View commit details
    Browse the repository at this point in the history

  2. Refactor constructor call visibility check

    @AbubakerB
    AbubakerB committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    51bf395 View commit details
    Browse the repository at this point in the history

  3. Clean ups!

    @AbubakerB
    AbubakerB committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    c87c3c5 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2015

  1. null check and only check signature visibility on Construct Kind.

    @AbubakerB
    AbubakerB committed Aug 12, 2015
    Configuration menu
    Copy the full SHA
    f66e66d View commit details
    Browse the repository at this point in the history

  2. Accept baselines

    @AbubakerB
    AbubakerB committed Aug 12, 2015
    Configuration menu
    Copy the full SHA
    5421ac8 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2015

  1. Addressed CR feedback

    @AbubakerB
    AbubakerB committed Sep 14, 2015
    Configuration menu
    Copy the full SHA
    ffec744 View commit details
    Browse the repository at this point in the history

  2. Changed error message for mismatching ctor signature

    @AbubakerB
    AbubakerB committed Sep 14, 2015
    Configuration menu
    Copy the full SHA
    0e8ecbd View commit details
    Browse the repository at this point in the history

  3. Addressed test PR feedback.

    @AbubakerB
    AbubakerB committed Sep 14, 2015
    Configuration menu
    Copy the full SHA
    3732fcd View commit details
    Browse the repository at this point in the history

  4. Accepted new baselines

    @AbubakerB
    AbubakerB committed Sep 14, 2015
    Configuration menu
    Copy the full SHA
    f2d3b29 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2015

  1. Addressed PR feedback - Amended diagnostic messages

    @AbubakerB
    AbubakerB committed Sep 15, 2015
    Configuration menu
    Copy the full SHA
    35fceb9 View commit details
    Browse the repository at this point in the history

  2. Accept baselines

    @AbubakerB
    AbubakerB committed Sep 15, 2015
    Configuration menu
    Copy the full SHA
    f6d8a0c View commit details
    Browse the repository at this point in the history