Fix type inference regression #34607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@typescript-bot test this |
|
Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 82019d6. You can monitor the build here. It should now contribute to this PR's status checks. |
|
Heya @ahejlsberg, I've started to run the extended test suite on this PR at 82019d6. You can monitor the build here. It should now contribute to this PR's status checks. |
4 tasks
|
The RWC tests are clean and the DT test failures are pre-existing conditions. So, looks good. |
RyanCavanaugh
approved these changes
Oct 21, 2019
jfsiii
pushed a commit
to jfsiii/kibana
that referenced
this pull request
Oct 30, 2019
Issues are described in DefinitelyTyped/DefinitelyTyped#38271 Root cause is stated to be an issue with TS microsoft/TypeScript#34607 which has since been fixed in master. Commiting now to prevent issues, but would also like to revert this and try again when TS fix ships (TS 3.7?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33490.