Fix export=global auto-import exclusion #32898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@typescript-bot cherry-pick this into release-3.6 |
|
Hey @RyanCavanaugh, I've opened #32900 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Aug 14, 2019
Component commits: 7f6543c Fix export=global auto import exclusion
sheetalkamat
approved these changes
Aug 14, 2019
RyanCavanaugh
pushed a commit
that referenced
this pull request
Aug 14, 2019
Component commits: 7f6543c Fix export=global auto import exclusion
timsuchanek
pushed a commit
to timsuchanek/TypeScript
that referenced
this pull request
Sep 11, 2019
|
Well, it's back... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30471
If any declaration of a symbol is global, then a global is available. Conversely, every declaration of what
export=resolves to has to be in an ES6 module in order for us to give you an auto-import.