Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement ts-ignore #31168

Closed
wants to merge 2 commits into from
Closed

Conversation

sottar
Copy link

@sottar sottar commented Apr 30, 2019

Fixes #31147

@msftclas
Copy link

msftclas commented Apr 30, 2019

CLA assistant check
All CLA requirements met.

@sottar
Copy link
Author

sottar commented Apr 30, 2019

I'm not sure why the test is failed... Could someone help me?

@IllusionMH
Copy link
Contributor

@sottar looks like your changes affect test in tests/cases/compiler/checkJsFiles_skipDiagnostics.ts
See Managing the baselines section in CONTRIBUTING.md

You should review files under tests/baselines/local with simalar files in tests/baselines/reference. In your case you can expand Raw output to see that there is reported diff in checkJsFiles_skipDiagnostics.types and checkJsFiles_skipDiagnostics.symbols. Thise files were affected since you've added new test cases to tests/cases/compiler/checkJsFiles_skipDiagnostics.ts

You should compare them and if changes are expected - use gulp baseline-accept command to accept changes.

If this will help to understand - principle is similar to one used in Jest snapshot testing.

@sottar
Copy link
Author

sottar commented Apr 30, 2019

@IllusionMH I applied gulp baseline-accept command, and it passed the test. Thank you for your comment!

@RyanCavanaugh
Copy link
Member

We're not able to review PRs that don't have approved issues associated with them. Please consult the PR template:

Please verify that:
* [ ] There is an associated issue in the `Backlog` milestone (**required**)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make @ts-ignore available when using {/* @ts-ignore */}.
4 participants