add code fix convert to mapped object type #24286
Conversation
Kingwl
changed the title
Kingwl
changed the title
|
some formatting issue with #24312 |
|
@andy-ms can you please review this change. |
|
|
||
| function getFixableSignatureAtPosition(sourceFile: SourceFile, pos: number): Info | undefined { | ||
| const token = getTokenAtPosition(sourceFile, pos, /*includeJsDocComment*/ false); | ||
| if (!isIndexSignatureParameterName(token)) return undefined; |
There was a problem hiding this comment.
Now that microsoft/vscode#45785 is fixed, might as well just assert these things as you go, which could save you some casts.
The only time this shouldn't be fixable is in a class, right? So in getCodeActions, all we should need to determine whether it's fixable is whether token.parent.parent.parent is a class?
There was a problem hiding this comment.
thanks, in my memory, i have not to use assert or cast (almost) 😬
There was a problem hiding this comment.
after thinking and search, This may exceed my expectations 😢
Kingwl
force-pushed
the
quick-fix-mapped-object-type
branch
from
e6ebb58
to
7f4aeee
Compare
|
Thanks! |
ghost
merged commit 
|
Can this be merged into 2.9 or 2.9.1? It'd be nice to have in 2.9 to line up with the current release notes which make me expect that this would be supported. |
|
No, this will be available in TypeScript 3.0 in two month, or in |
ghost
mentioned this pull request
Fixes #24220