Decorators not allowed in JS even with 'experimentalDecorators' set

[DanielRosenwasser]

1. Create a new folder.
2. Add a tsconfig.json/jsconfig.json.
3. Add "experimentalDecorators": true.
4. Create a new .js file that has a decorated class.

Expected: No error.
Actual: Error that you need to add "experimentalDecorators": true.

[billti]

Hmmm, isn't this exactly what #6881 fixed? Maybe a regression (though hard to say, as you didn't mention what build/branch you are using :-p ).

[billti]

p.s. Just tried it with a build from a couple days ago in master, and it works fine with the below tsconfig.json. It gives the error if I change the setting to false (as expected). Please provide a repro (and details on what branch/build) if you are sure you are seeing issues.

{
    "compilerOptions": {
        "experimentalDecorators": true,
        "allowJs": true
    }
}

[mhegazy]

i see this on latest too.

[DanielRosenwasser]

@mhegazy you see the behavior I'm reporting, or are you also saying it works for you?

@billti, @jramsay saw the same issue a few days ago as well. I used the nightly, so Version 1.9.0-dev.20160525-1.0.

[zhengbli]

Cannot repro this either. Talked to @mhegazy, turns out he had an invalid tsconfig when he saw this. Close until a repro can be found.

[akanieski]

I'm working on a TS project that's using gulp (+ aurelia-cli). Even with experimentalDecorators: true I still get red squigglies in VSCode.

{
  "compileOnSave": false,
  "compilerOptions": {
    "sourceMap": true,
    "target": "es5",
    "module": "amd",
    "declaration": false,
    "noImplicitAny": false,
    "removeComments": true,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "moduleResolution": "node",
    "lib": ["es2015", "dom"]
  },
  "exclude": [
    "node_modules"
  ],
  "filesGlob": [
    "./src/**/*.ts",
    "./test/**/*.ts",
    "./typings/index.d.ts",
    "./custom_typings/**/*.d.ts"
  ],
  "atom": {
    "rewriteTsconfig": false
  }
}

[akanieski]

I ran into this when I open a root folder that contains TS project for client and TS project for server (File-> Open Folder .. /root ). The root has no tsconfig file. VSCode does not respect the tsconfig in each respective project folder ( /root/server/tsconfig.json and /root/client/tsconfig.json ). It is expecting a tsconfig to be in the root of the folder opened in VSCode ( /root/tsconfig.json ).

When I open another instance of VSCode and open the /root/client or /root/server folder the decorator warning goes away, as it should.

Is this by design? I'm not sure i'd expect it to find the nearest tsconfig.json in local folder or above.

I hope I'm making sense :-P

[zhengbli]

@akanieski it shouldn't be the case, the tsconfig file in the same folder should be respected regardless where you open as root in VSCode. Can you provide a small sample of the issue for reproing? I tried on my machine but I didn't see it happen. Also with your tsconfig.json content, I didn't get the error for the decorators. What version of VSCode / TypeScript are you using?