Importing sometimes imports relative path instead of absolute when using project references

[Tyriar]

TypeScript Version: 3.5.2

Code

Auto importing CellData in https://github.com/xtermjs/xterm.js/blob/73521390d29c8a111058a6a7d08edd827ba498b7/src/browser/ColorManager.ts will import from ../../out/common instead of common/

See tsconfigs:

• ColorManager lives in https://github.com/xtermjs/xterm.js/blob/73521390d29c8a111058a6a7d08edd827ba498b7/src/browser/tsconfig.json
• CellData lives in https://github.com/xtermjs/xterm.js/blob/73521390d29c8a111058a6a7d08edd827ba498b7/src/common/tsconfig.json

Expected behavior:

import { CellData } from 'common/buffer/CellData';

Actual behavior:

import { CellData } from '../../out/common/buffer/CellData';

[andrewbranch]

TypeScript Version: 3.5.2

Hey @Tyriar, can you see if this is fixed for you now? There have been some changes around picking module specifiers in the last couple versions, and I can’t repro this in 3.6 or 3.7.

[Tyriar]

This does seem to be fixed when using TS 3.7.2, thanks!

[bpasero]

@andrewbranch there is still an issue where implementing an interface puts these ugly inline imports that are relative:

Is this known?

[andrewbranch]

@bpasero I’ve fixed a similar issue to that before so I know exactly why that’s happening, but unfortunately each of these needs to be addressed in its own separate codefix/refactor. Would you mind opening a new bug and mentioning me?

[bpasero]

@andrewbranch #34995

[Tyriar]

@andrewbranch this still seems to happen when importing from the same project:

Notice TS version in bottom and proposed auto import.

Expected is:

import { blend } from 'browser/Color';