Organize Imports doesn't sort '_' as tslint expects it

[henry-alakazhang]

TypeScript Version: 3.0.0-dev.20180620
vscode Version: 1.24.0 (6a6e02cef0f2122ee1469765b704faf5d0e0d859 2018-06-06T17:37:01.579Z)
OS Version: Ubuntu 16.04 LTS

Search Terms: organise organize imports tslint

Code

import { foo, _bar } from 'baz';

Expected behavior: tslint expects the imports to have _ before alphabetic characters, so Organize Imports should sort it to import { _bar, foo }

Actual behavior: It sorts it to import { foo, _bar }, which causes a tslint error.

[mhegazy]

A PR would be appreciated.

[Shobhit1]

I can try my hands on this one, if no one else is working on it!

[henry-alakazhang]

It looks like the issue is just using toUpperCase vs. tslint using toLowerCase, but given this

    /* ...
     * 
     * Case-insensitive comparisons compare both strings one code-point at a time using the integer
     * value of each code-point after applying `toUpperCase` to each string. We always map both
     * strings to their upper-case form as some unicode characters do not properly round-trip to
     * lowercase (such as `ẞ` (German sharp capital s)).
     */

in core.ts:1698, should tslint be changed instead?

[Shobhit1]

I would agree that changing the core.ts file in a stable sort function will not be a good idea. May be exploring the possibility of a change in tslint is the way to go.

[aboyton]

I've raised an issue with TSLint palantir/tslint#4063 and submitted a pull request there palantir/tslint#4064, so let's see what they think about fixing this on their end.

[suhailsinghbains]

Hi,
I'm new to open-source, can I solve this issue as it is still open?
Thanks