[Suggestion] No suggestions in workspace which ask programmers to convert a CommonJS module into an ES6 module

[mjbvz]

From @momocow on April 9, 2018 3:23

As in #47299, it is obvious to say that many people got annoyed by those ... under our lovely require expression.

I suggest VSC to ask programmers which import style is more preferable based on project by popups (or any fashion that does not persist in workspace).

I have to say that I'm not a conservative who dislikes changing and learning new things. I do love ES6 style but not in NodeJS modules.

Here's my reason.
ES6 modules break some already-existing features of NodeJS, i.e. optional dependencies Once you import a dependency module in an ES6 fashion, you should also install it to make it work. Thus there will be no optional dependencies in ES6 modules. (ES6 modules cannot perform conditional imports)

It is always welcome for someone to correct me if I do mistake something and I must say that I love coding with VSC.
Happy coding everyone 😄

Copied from original issue: microsoft/vscode#47458

[mjbvz]

@Andy-MS Should this suggestion perhaps be disabled by certain module or target settings in a jsconfig?

[mhegazy]

// CC @DanielRosenwasser

that is something we were concerned about.. so we need to address that.

@Andy-MS let's chat about what needs to be done here..

one option is to disable this suggestion by default, and have a configuration option to enable it.
the other is to enable it only if we module !== commonJS

[ferrao]

@mhegazy I am guessing your second option will not work for people using relative CommonJS modules, as we need module: system to trigger the classic module resolution strategy: microsoft/vscode#47619

[mhegazy]

not sure why you need system. you can just set "moduleResolution": "classic" in your config file.

[ferrao]

@mhegazy I am not sure either, but it only works with system, as recommended in microsoft/vscode#47619. For some reason, "moduleResoluton": "classic" does not work.

[mhegazy]

I will need more context to be able to diagnose your issue.. here is what i am seeing:

[ferrao]

It works with your config @mhegazy, I had not seen that moduleConfig option before. It is not in here and that is why I did not saw it.