Auto import suggestions in TS 2.6 : wrong strategy for import paths

[cyrilletuzi]

TypeScript Version: 2.7.0-dev.20171102
VSCode Version: Insiders, same date

Code

In an Angular project, start typing any Angular code, like :

@Inp

and select the auto-import suggestion.

Expected behavior:

Should import top level export :

import { Input } from '@angular/core';

Actual behavior:

Imports deep level export :

import { Input } from '@angular/core/src/metadata/directives';

It was handled fine when just one auto-import was suggested (see #19417).

Also, there was the same issue with the Import quick fix (#15223), but which was resolved a long time ago.

@mhegazy @mjbvz

Currently we dedupe by always pointing you to the original rather than a re-export.
We could be smarter by comparing all re-exports of the same symbol and choosing the one with the smallest path. We should probably do that in completion details rather than entries to save work, meaning the completion identifier would still use the source of the original export.

[mhegazy]

We should always get the top most file, and not the source. usually the source is buried deep inside the module guts.

[cyrilletuzi]

Can't we just use the same code from the import quick fix ?

[mhegazy]

Some duplicates of this issue:

• Duplicate auto import suggestions returned for @angular/material #19922
• Duplicate auto import suggestions with re-exports #19889
• Autoimport does not respect TS re-export files #19888
• angular4 autoimport problem #17705

@Andy-MS let's verify that the fix does indeed fix all these cases.