JS Doc type intellisense not working when using custom file extension

[waderyan]

From @csvenke on September 30, 2016 20:52

• VSCode Version: 1.5.3
• OS Version: Windows 10

In a .js file, intellisense provides correct jsdoc types

In a custom extension file associated with javascript, types from jsdoc are not provided

Steps to Reproduce:

1. Create a .sj file
2. In settings.json, set "files.associations": { "*.sj": "javascript" }
3. Create a function with jsdoc parameters with types
4. Call function and check if intellisense provides types

Copied from original issue: microsoft/vscode#13100

[waderyan]

@csvenke thank you for opening this issue. This is a great find!

@dbaeumer I have recreated this with latest TS and VS Code Insiders.

Here is the code to copy and paste.

/**
 * @param {string} a
 * @param {string} b
 * @param {string} c
 */
function asd(a, b, c) {}

Do you think this is on our end or on TS's end?

[waderyan]

From @dbaeumer on October 4, 2016 10:13

@waderyan a TS issue since the hover is computed by the tsserver. Is this with 1.6 insider. I thought they fixed this in 2.0.x since we reported this on 1.8.x already.

[waderyan]

@dbaeumer this is with 1.6. I'll open an issue on their repo.

[mhegazy]

@dbaeumer and @waderyan, looking at the log, i do not see VSCode sending scriptKindName in the open request. the result is that the server does not know what mode you want it to be in. it treats it as TS by default if the value is not specified. specifying the value as "JS" should address this issue.

closing for now.

[dbaeumer]

@mhegazy the reason why we don't send the scriptKind in this situation is that it will only work for a single file and is more confusing at the end. Consider the case a user as

a.sj
b.sj where b.sj import a.sj with `import * as a from 'a';

If we set the ScriptKind of b.sj to JavaScript everything works in b.sj except the users gets an error on the import and a.<code complete> will not propose anything.

So instead setting the ScriptKind the tsserver should support extension sets. I think you have a request for that.

There is one exception where we do set the ScriptKind. If a file has no extension and has a #! node... first line.