Enabling typedef tslint rule for taco packages #58
Conversation
Conflicts: src/remotebuild/resources/en/resources.json
taco-dependency-installer,taco-kits,taco-remote,taco-remote-lib,taco-remote-multiplexer,taco-utils
| private static debug = false; | ||
| private static CERT_DEFAULTS = { | ||
| private static debug: boolean = false; | ||
| private static CERT_DEFAULTS: any = { |
There was a problem hiding this comment.
Please put the proper type for this variable. With any, you can use any members, like dayss and the compiler will allow it. If you leave it untyped, typescript deduces the proper type, so trying to use Certs.CERT_DEFAULTS.dayss gives this error:
remotebuild\lib\darwin\darwinCerts.ts(227,64): error TS2339: Property 'dayss' does not exist on type '{ days: number; country: string; ca_cn: string; pfx_name: string; client_cn: string; }'.
Incorporating PR feedback from @digeff Conflicts: src/taco-cli/cli/plugin.ts src/taco-cli/test/cordovaWrapper.ts
Conflicts: src/taco-cli/cli/build.ts src/taco-cli/cli/utils/buildTelemetryHelper.ts src/taco-cli/cli/utils/settings.ts src/taco-cli/test/platformHelper.ts
| var valueToSerialize: string = kitProject ? self.commandParameters.data.options["kit"] : self.commandParameters.data.options["cordova"]; | ||
|
|
||
| return projectHelper.createTacoJsonFile(self.commandParameters.cordovaParameters.projectPath, kitProject, valueToSerialize); | ||
| }) | ||
| .then(function (): Q.Promise<any> { |
There was a problem hiding this comment.
Looks like the space between "function" and "()" has been deleted in some files but not in many other files. Lets be consistent here.
| @@ -122,7 +122,7 @@ describe("server", function (): void { | |||
| fs.existsSync(path.join(certsDir, "ca-key.pem")).should.be.ok; | |||
| fs.existsSync(path.join(certsDir, "ca-cert.pem")).should.be.ok; | |||
| }).then(function (): Q.Promise<{}> { | |||
| var deferred = Q.defer(); | |||
| var deferred: Q.Deferred<any> = Q.defer(); | |||
| // Disabling strict SSL for unit testing | |||
| request.get({ url: "https://localhost:3000", strictSSL: false }, function (error: any, response: any, body: any): void { | |||
There was a problem hiding this comment.
According to this file: https://github.com/borisyankov/DefinitelyTyped/blob/master/request/request.d.ts it seems that response is a http.IncomingMessage
|
👍 with comments above. |
keeping type inferences work by themselves for anonymous objects
Conflicts: src/taco-utils/tacoPackageLoader.ts
Enabling typedef tslint rule (with variable-declaration off) for taco packages
No description provided.