-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate convenience methods on Instrument classes #6086
base: main
Are you sure you want to change the base?
Conversation
The aim is to reduce the number of ways in which the same operation can be performed
dcaedae
to
de2e9c2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6086 +/- ##
==========================================
- Coverage 67.61% 67.61% -0.01%
==========================================
Files 351 351
Lines 30549 30561 +12
==========================================
+ Hits 20656 20663 +7
- Misses 9893 9898 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I support this deprecation. The only usefulness related to this that I can recall is calling parameters/methods/functions on channel lists, but that I already implemented and work for both proper parameters and bound methods (right?)
Yes, there was a limitation where you could not call a method on more than one channel (which was an advantage of a qcodes function) but that has since been lifted. |
Following the discussion in #6080 I think we should consider getting rid of these methods on the instrument classes.
All of this functionality can be done in ways that is more obvious, direct and more frequently used
E.g. parameter and functions can be looked up from the
parameters
andfunctions
delegate attr dicts if you need to look them up dynamically.