Make warnings hard errors in the test suite #5507
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does not work since the min ver job still triggers lots of deprecation warnings |
Codecov Report
@@ Coverage Diff @@
## main #5507 +/- ##
==========================================
- Coverage 66.31% 66.30% -0.01%
==========================================
Files 354 354
Lines 30951 30951
==========================================
- Hits 20526 20523 -3
- Misses 10425 10428 +3 |
jenshnielsen
force-pushed
the
warnings_as_error_
branch
from
b27f12a
to
764536e
Compare
jenshnielsen
force-pushed
the
warnings_as_error_
branch
from
764536e
to
c12c43c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5507 +/- ##
==========================================
- Coverage 67.55% 67.54% -0.01%
==========================================
Files 348 348
Lines 30251 30251
==========================================
- Hits 20437 20434 -3
- Misses 9814 9817 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And silence the one remaing warning