Reducing qcodes import times #4616
Conversation
for more information, see https://pre-commit.ci
|
And also, I do not no how to run qcodes test and check if I didn't break anything ^^'. |
|
Thanks, I will try to have a look asab and see if I can figure out why/if pandas is still being imported eagerly |
Since xarray imports pandas, this also make pandas lazy import
… into decrease-import-time
for more information, see https://pre-commit.ci
|
Found out that pandas was imported by xarray so I passed xarray in lazy import. On the data_set file, I got some error and had to write the type of some parameters as |
… into decrease-import-time
|
Yep, forget what I wrote, it is fixed. |
for more information, see https://pre-commit.ci
Since xarray imports pandas, this also make pandas lazy import
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
jenshnielsen
force-pushed
the
decrease-import-time
branch
from
dcd07e6
to
817b67b
Compare
|
Looks good. Did you verify that you need to also make changes to the tests. Importing qcodes should not import the tests module. If it does that seems like a bug we should also fix. |
|
You right, test file do not matters. |
for more information, see https://pre-commit.ci
… into decrease-import-time
for more information, see https://pre-commit.ci
… into decrease-import-time
|
Alright there is maybe the import of Monitor to work on but I am waiting opinion(s) from others. |
… into decrease-import-time
for more information, see https://pre-commit.ci
… into decrease-import-time
|
Should be good |
for more information, see https://pre-commit.ci
|
Done. I did not get what you meant by "documentation about where to import it from"... |
for more information, see https://pre-commit.ci
… into decrease-import-time
for more information, see https://pre-commit.ci
|
Looks good. thanks @edumur |
|
bors merge |
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
bors merge |
Hi all,
Following this discussion #4565 and this issue #4543 I am proposing this pull request to work on reducing qcodes loading time.
I have started with pandas.
I tried to propagate what @jenshnielsen did to make pandas import lazy-import.
I am not sure I have succeeded since I still see pandas being imported while doing
importtime-waterfall.I would gladly improve the request if someone help me on this.
If this becomes a successful endeavor, I will continue by making other import lazy-import.