Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrument convert attrs to properties #4417

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Instrument convert attrs to properties #4417

wants to merge 4 commits into from

Commits on Jul 25, 2022

  1. Replace instrument attrs with properties 

    Fixes issue with autodocsumm and is probably more clean
    @jenshnielsen
    jenshnielsen committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    1a33293 View commit details
    Browse the repository at this point in the history

  2. replace metadata attr with property

    @jenshnielsen
    jenshnielsen committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    bdcf275 View commit details
    Browse the repository at this point in the history

  3. use private attrs for delegate attrs dict

    @jenshnielsen
    jenshnielsen committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    4789aba View commit details
    Browse the repository at this point in the history

  4. remove tests that rely on parameters being an attr

    @jenshnielsen
    jenshnielsen committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    5ba252c View commit details
    Browse the repository at this point in the history