Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DelegateParameterWithSetpoints #3849

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

astafan8
Copy link
Contributor

@astafan8 astafan8 commented Jan 20, 2022

todo:

  • bind_to_instrument
  • inherit unit and label
  • Take care of the cache, e.g. Disable it :)
  • Smarter handling of validators - create new validators for the delegates with the same shape as source parameters if the provided delegate parameters dont exist.
  • Let the user pass instances of DelegateParameter for each setpoint, giving full flexibility to the users
  • test all behavior

@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #3849 (68d2870) into master (cf8dbc0) will decrease coverage by 0.05%.
The diff coverage is 29.54%.

❗ Current head 68d2870 differs from pull request most recent head 9b30a35. Consider uploading reports for the commit 9b30a35 to get more accurate results

@@            Coverage Diff             @@
##           master    #3849      +/-   ##
==========================================
- Coverage   65.64%   65.59%   -0.06%     
==========================================
  Files         228      228              
  Lines       31033    31077      +44     
==========================================
+ Hits        20371    20384      +13     
- Misses      10662    10693      +31     

@astafan8 astafan8 added this to the 0.33.0 milestone Jan 24, 2022
@astafan8 astafan8 modified the milestones: 0.33.0, 0.34.0 Feb 16, 2022
@astafan8 astafan8 modified the milestones: 0.34.0, 0.35.0 Jun 3, 2022
@astafan8 astafan8 modified the milestones: 0.35.0, 0.37.0 Sep 9, 2022
@astafan8
Copy link
Contributor Author

@jenshnielsen i'd like to re-target and re-base this branch when we move to "main" in qcodes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant