Changed API endpoint, Fixes #11 #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @cagbal, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
Hi, I am closing and re-opening this PR to bump the CLA bot. Sorry for the inconvenience! |
piotrek1543
reviewed
Aug 3, 2017
| import java.util.HashMap; | ||
|
|
||
|
|
||
| public class VisionServiceRestClientNew implements VisionServiceClient { |
There was a problem hiding this comment.
I wonder if there wouldn't be better and much clearer if prefix new would be at the beginning = I mean NewVisionServiceRestClient.
piotrek1543
approved these changes
Aug 3, 2017
|
Hi @piotrek1543. My naming was a bit bad! I committed your suggestion. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not modify com.microsoft.projectoxford.vision.VisionServiceRestClient file; therefore, created a new class(com.microsoft.mimickeralarm.utilities.VisionServiceRestClientNew) which is the same with this, but the API strings are up-to-date.
I know it's not the best way, but now, the color reasoning seems working.