Merge branch 'main' into dev/cazamor/cmdNotFound-upgrade

.github/actions/spell-check/allow/names.txt

@@ -94,6 +94,7 @@ Melman
 Mikhayelyan
 msft
 Myrvold
+nathancartlidge
 Nemeth
 nielslaute
 oldnewthing

.github/actions/spell-check/expect.txt

@@ -29,6 +29,7 @@ AFFINETRANSFORM
 AFX
 AGGREGATABLE
 AHybrid
+AKV
 ALarger
 ALLAPPS
 ALLINPUT

.github/copilot-workspace/policy.json

@@ -0,0 +1,4 @@
+{
+  "allowPullRequests": false,
+  "allowComments": false
+}

.pipelines/ESRPSigning_core.json

@@ -304,6 +304,7 @@
                 "MessagePack.dll",
                 "Nerdbank.Streams.dll",
                 "WinUI3Apps\\SharpCompress.dll",
+                "WinUI3Apps\\ZstdSharp.dll",
                 "ColorCode.Core.dll", 
                 "ColorCode.UWP.dll",
                 "UnitsNet.dll",

.pipelines/installer-steps.yml

@@ -11,6 +11,9 @@ parameters:
   - name: installerPrefix
     type: string
     default: "PowerToysSetup"
+  - name: signingParameters
+    type: object
+    default: {}
 
 steps:
   - task: VSBuild@1
@@ -24,10 +27,10 @@ steps:
       clean: true
       maximumCpuCount: true
 
-  - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@3
+  - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@5
     displayName: Sign PowerToysSetupCustomActions DLL
     inputs:
-      ConnectedServiceName: "Terminal/Console/WinAppDriver Team Code Signing Connection"
+      ${{ insert }}: ${{ parameters.signingParameters }}
       FolderPath: 'installer/PowerToysSetupCustomActions/$(BuildPlatform)\$(BuildConfiguration)\${{parameters.buildSubDir}}'
       signType: batchSigning
       batchSignPolicyFile: '$(build.sourcesdirectory)\.pipelines\ESRPSigning_installer.json'
@@ -74,10 +77,10 @@ steps:
       scriptName: .pipelines/versionAndSignCheck.ps1
       arguments: -targetDir '$(build.sourcesdirectory)\extractedMsi\Binary'
 
-  - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@3
+  - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@5
     displayName: Sign MSI
     inputs:
-      ConnectedServiceName: "Terminal/Console/WinAppDriver Team Code Signing Connection"
+      ${{ insert }}: ${{ parameters.signingParameters }}
       FolderPath: 'installer/PowerToysSetup/$(BuildPlatform)\$(BuildConfiguration)\${{parameters.buildSubDir}}'
       signType: batchSigning
       batchSignPolicyFile: '$(build.sourcesdirectory)\.pipelines\ESRPSigning_installer.json'
@@ -101,10 +104,10 @@ steps:
     inputs:
       script: '"C:\Program Files (x86)\WiX Toolset v3.14\bin\insignia.exe" -ib installer\PowerToysSetup\$(BuildPlatform)\$(BuildConfiguration)\${{parameters.buildSubDir}}\${{parameters.installerPrefix}}-${{ parameters.versionNumber }}-$(BuildPlatform).exe -o installer\engine.exe'
 
-  - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@3
+  - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@5
     displayName: "ESRP CodeSigning (Engine)"
     inputs:
-      ConnectedServiceName: "Terminal/Console/WinAppDriver Team Code Signing Connection"
+      ${{ insert }}: ${{ parameters.signingParameters }}
       FolderPath: "installer"
       Pattern: engine.exe
       signConfigType: inlineSignParams
@@ -137,10 +140,10 @@ steps:
     inputs:
       script: '"C:\Program Files (x86)\WiX Toolset v3.14\bin\insignia.exe" -ab installer\engine.exe installer\PowerToysSetup\$(BuildPlatform)\$(BuildConfiguration)\${{parameters.buildSubDir}}\${{parameters.installerPrefix}}-${{ parameters.versionNumber }}-$(BuildPlatform).exe -o installer\PowerToysSetup\$(BuildPlatform)\$(BuildConfiguration)\${{parameters.buildSubDir}}\${{parameters.installerPrefix}}-${{ parameters.versionNumber }}-$(BuildPlatform).exe'
 
-  - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@3
+  - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@5
     displayName: Sign Bootstrapper
     inputs:
-      ConnectedServiceName: "Terminal/Console/WinAppDriver Team Code Signing Connection"
+      ${{ insert }}: ${{ parameters.signingParameters }}
       FolderPath: 'installer/PowerToysSetup/$(BuildPlatform)\$(BuildConfiguration)\${{parameters.buildSubDir}}'
       signType: batchSigning
       batchSignPolicyFile: '$(build.sourcesdirectory)\.pipelines\ESRPSigning_installer.json'

.pipelines/release.yml

@@ -23,6 +23,15 @@ parameters:
   - name: versionNumber
     type: string
     default: '0.0.1'
+  - name: signingParameters
+    type: object
+    default:
+      ConnectedServiceName: $(SigningServiceName)
+      AppRegistrationClientId: $(SigningAppId)
+      AppRegistrationTenantId: $(SigningTenantId)
+      AuthAKVName: $(SigningAKVName)
+      AuthCertName: $(SigningAuthCertName)
+      AuthSignCertName: $(SigningSignCertName)
 
 extends:
   template: v1/1ES.Official.PipelineTemplate.yml@1ESPipelineTemplates
@@ -164,10 +173,10 @@ extends:
             maximumCpuCount: true
 
         ### BEGIN SECTION - build and sign nuget packages for abstracted UI utils
-        - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@3
+        - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@5
           displayName: Sign Utilities libraries
           inputs:
-            ConnectedServiceName: 'Terminal/Console/WinAppDriver Team Code Signing Connection'
+            ${{ insert }}: ${{ parameters.signingParameters }}
             FolderPath: 'src/modules'
             signType: batchSigning
             batchSignPolicyFile: '$(build.sourcesdirectory)\.pipelines\ESRPSigning_abstracted_utils_dll.json'
@@ -207,10 +216,10 @@ extends:
             flattenFolders: True
             targetFolder: $(Build.ArtifactStagingDirectory)/nupkg
 
-        - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@3
+        - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@5
           displayName: Submit *.nupkg to ESRP for code signing
           inputs:
-            ConnectedServiceName: 'Terminal/Console/WinAppDriver Team Code Signing Connection'
+            ${{ insert }}: ${{ parameters.signingParameters }}
             FolderPath: $(Build.ArtifactStagingDirectory)/nupkg
             Pattern: '*.nupkg'
             UseMinimatch: true
@@ -412,28 +421,28 @@ extends:
       # reference https://dev.azure.com/microsoft/Dart/_git/AppDriver?path=/ESRPSigning.json&version=GBarm64-netcore&_a=contents for winappdriver
       # https://dev.azure.com/microsoft/Dart/_git/AppDriver?path=/CIPolicy.xml&version=GBarm64-netcore&_a=contents
 
-        - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@3
+        - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@5
           displayName: Sign Core PT
           inputs:
-            ConnectedServiceName: 'Terminal/Console/WinAppDriver Team Code Signing Connection'
+            ${{ insert }}: ${{ parameters.signingParameters }}
             FolderPath: '$(BuildPlatform)/$(BuildConfiguration)' # Video conf uses x86 and x64.
             signType: batchSigning
             batchSignPolicyFile: '$(build.sourcesdirectory)\.pipelines\ESRPSigning_core.json'
             ciPolicyFile: '$(build.sourcesdirectory)\.pipelines\CIPolicy.xml'
 
-        - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@3
+        - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@5
           displayName: Sign DSC Powershell files
           inputs:
-            ConnectedServiceName: 'Terminal/Console/WinAppDriver Team Code Signing Connection'
+            ${{ insert }}: ${{ parameters.signingParameters }}
             FolderPath: 'src/dsc/Microsoft.PowerToys.Configure'
             signType: batchSigning
             batchSignPolicyFile: '$(build.sourcesdirectory)\.pipelines\ESRPSigning_DSC.json'
             ciPolicyFile: '$(build.sourcesdirectory)\.pipelines\CIPolicy.xml'
 
-        - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@3
+        - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@5
           displayName: Sign x86 directshow VCM
           inputs:
-            ConnectedServiceName: 'Terminal/Console/WinAppDriver Team Code Signing Connection'
+            ${{ insert }}: ${{ parameters.signingParameters }}
             FolderPath: 'x86/$(BuildConfiguration)' # Video conf uses x86 and x64.
             signType: batchSigning
             batchSignPolicyFile: '$(build.sourcesdirectory)\.pipelines\ESRPSigning_vcm.json'
@@ -477,6 +486,7 @@ extends:
 
         - template: .pipelines/installer-steps.yml@self
           parameters:
+            signingParameters: ${{ parameters.signingParameters }}
             versionNumber: ${{ parameters.versionNumber }}
             perUserArg: "false"
             buildSubDir: "MachineSetup"
@@ -491,6 +501,7 @@ extends:
 
         - template: .pipelines/installer-steps.yml@self
           parameters:
+            signingParameters: ${{ parameters.signingParameters }}
             versionNumber: ${{ parameters.versionNumber }}
             perUserArg: "true"
             buildSubDir: "UserSetup"

Directory.Packages.props

@@ -57,7 +57,7 @@
     <PackageVersion Include="NLog.Extensions.Logging" Version="5.3.8" />
     <PackageVersion Include="NLog.Schema" Version="5.2.8" />
     <PackageVersion Include="ScipBe.Common.Office.OneNote" Version="3.0.1" />
-    <PackageVersion Include="SharpCompress" Version="0.33.0" />
+    <PackageVersion Include="SharpCompress" Version="0.37.2" />
     <PackageVersion Include="StreamJsonRpc" Version="2.14.24" />
     <PackageVersion Include="StyleCop.Analyzers" Version="1.2.0-beta.556" />
     <!-- Package System.CodeDom added as a hack for being able to exclude the runtime assets so they don't conflict with 8.0.1. This is a dependency of System.Management but the 8.0.1 version wasn't published to nuget. -->
@@ -72,7 +72,7 @@
     <PackageVersion Include="System.Diagnostics.EventLog" Version="8.0.0" />
     <!-- Package System.Diagnostics.PerformanceCounter added as a hack for being able to exclude the runtime assets so they don't conflict with 8.0.1. This is a dependency of System.Data.OleDb but the 8.0.1 version wasn't published to nuget. -->
     <PackageVersion Include="System.Diagnostics.PerformanceCounter" Version="8.0.0" />
-    <PackageVersion Include="System.Drawing.Common" Version="8.0.4" />
+    <PackageVersion Include="System.Drawing.Common" Version="8.0.5" />
     <PackageVersion Include="System.IO.Abstractions" Version="17.2.3" />
     <PackageVersion Include="System.IO.Abstractions.TestingHelpers" Version="17.2.3" />
     <PackageVersion Include="System.Management" Version="8.0.0" />
@@ -95,4 +95,4 @@
     <PackageVersion Include="Microsoft.VariantAssignment.Client" Version="2.4.17140001" />
     <PackageVersion Include="Microsoft.VariantAssignment.Contract" Version="3.0.16990001" />
   </ItemGroup>
-</Project>
+</Project>

NOTICE.md

@@ -1342,7 +1342,7 @@ EXHIBIT A -Mozilla Public License.
 - NLog.Extensions.Logging 5.3.8
 - NLog.Schema 5.2.8
 - ScipBe.Common.Office.OneNote 3.0.1
-- SharpCompress 0.33.0
+- SharpCompress 0.37.2
 - StreamJsonRpc 2.14.24
 - StyleCop.Analyzers 1.2.0-beta.556
 - System.CodeDom 8.0.0
@@ -1353,7 +1353,7 @@ EXHIBIT A -Mozilla Public License.
 - System.Data.SqlClient 4.8.6
 - System.Diagnostics.EventLog 8.0.0
 - System.Diagnostics.PerformanceCounter 8.0.0
-- System.Drawing.Common 8.0.4
+- System.Drawing.Common 8.0.5
 - System.IO.Abstractions 17.2.3
 - System.IO.Abstractions.TestingHelpers 17.2.3
 - System.Management 8.0.0

doc/thirdPartyRunPlugins.md

@@ -35,6 +35,7 @@ Contact the developers of a plugin directly for assistance with a specific plugi
 | [Currency Converter](https://github.com/Advaith3600/PowerToys-Run-Currency-Converter) | [advaith3600](https://github.com/advaith3600) | Convert real and crypto currencies |
 | [FastWeb](https://github.com/CCcat8059/FastWeb) | [CCcat](https://github.com/CCcat8059) | Open website in browser |
 | [WebSearchShortcut](https://github.com/Daydreamer-riri/PowerToys-Run-WebSearchShortcut) | [Riri](https://github.com/Daydreamer-riri) | Select a specific search engine to perform searches. |
+| [UnicodeInput](https://github.com/nathancartlidge/powertoys-run-unicode) | [nathancartlidge](https://github.com/nathancartlidge) | Copy Unicode characters to the clipboard |
 
 ## Extending software plugins
 

installer/PowerToysSetup/Product.wxs

@@ -410,7 +410,9 @@
         <Directory Id="ApplicationProgramsFolder" Name="PowerToys (Preview)"/>
       </Directory>
       <Directory Id="DesktopFolder" Name="Desktop" />
-      <Directory Id="PersonalFolder" Name="UserHomeDocuments" />
+      <?if $(var.PerUser) = "true" ?>
+        <Directory Id="PersonalFolder" Name="UserHomeDocuments" />
+      <?endif?>
     </Directory>
   </Fragment>
 </Wix>