Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sendSMS connector files: Swagger, apiProperties, and README #3481

Closed
wants to merge 5 commits into from

Conversation

ElenaMainerici
Copy link
Contributor


When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)

If this is your first time submitting to GitHub and you need some help, please sign up for this session.

  • I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
  • I attest that the connector works and I verified by deploying and testing all the operations.
  • I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
  • I attest that I have added response schemas to my actions, unless the response schema is dynamic.
  • I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
  • If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

  • I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
  • Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
  • Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
  • If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

@ElenaMainerici ElenaMainerici requested a review from a team as a code owner May 11, 2024 07:56
@ElenaMainerici
Copy link
Contributor Author

ElenaMainerici commented May 11, 2024 via email

Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ElenaMainerici,

Kindly resolve review comments.

@ElenaMainerici
Copy link
Contributor Author

Hi @vmanoharas,

I've updated the Swagger configuration for the SendSMS connector based on your feedback. Here's what I changed:

  • Updated response schemas for more accurate information.
  • Improved visibility settings for parameters in the UI.
  • Added necessary security details and updated metadata.

Could you take a look when you have a moment? I appreciate your help and am open to any further suggestions to make sure everything is top-notch.

Thanks!

@vmanoharas
Copy link
Contributor

Hi @vmanoharas,

I've updated the Swagger configuration for the SendSMS connector based on your feedback. Here's what I changed:

  • Updated response schemas for more accurate information.
  • Improved visibility settings for parameters in the UI.
  • Added necessary security details and updated metadata.

Could you take a look when you have a moment? I appreciate your help and am open to any further suggestions to make sure everything is top-notch.

Thanks!

Thanks you very much @ElenaMainerici, will review and provide my feedback/approval.

Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ElenaMainerici,

Kindly fix one comment.

@ElenaMainerici
Copy link
Contributor Author

Done :)

Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ElenaMainerici,

Thank you very much for resolving issues.

Your merge commit has an issue, it has not merged properly, please refer the apiProperties validation checker error. Please recommit or close this PR and open a new PR. Please don't merge it until the review is completed.

image

@sendSMS-RO sendSMS-RO closed this by deleting the head repository May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants