Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ubiqod by Skiply v2 connector #3417

Closed
wants to merge 0 commits into from
Closed

Conversation

Sylvain-Chu
Copy link
Contributor

@Sylvain-Chu Sylvain-Chu commented Apr 26, 2024


When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)

If this is your first time submitting to GitHub and you need some help, please sign up for this session.

  • I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
  • I attest that the connector works and I verified by deploying and testing all the operations.
  • I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
  • I attest that I have added response schemas to my actions, unless the response schema is dynamic.
  • I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
  • If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

This pull request adds a new Ubiqod By Skiply v2 connector. With version 1 being deprecated, we are creating another one with a brand new API and lots of new features.

@Sylvain-Chu Sylvain-Chu requested a review from a team as a code owner April 26, 2024 08:35
@Sylvain-Chu
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Skiply"

Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Sylvain-Chu

Your merge commit has an issue, it has not merged properly, please refer the Swagger validation checker errors, and apiProperties.json file cannot be picked by validator. Please recommit or close this PR and open a new PR. Please don't merge it until the review is completed.

@vmanoharas
Copy link
Contributor

Hello @Sylvain-Chu

Your merge commit has an issue, it has not merged properly, please refer the Swagger validation checker errors, and apiProperties.json file cannot be picked by validator. Please recommit or close this PR and open a new PR. Please don't merge it until the review is completed.

@Sylvain-Chu
Copy link
Contributor Author

Hello @Sylvain-Chu

Your merge commit has an issue, it has not merged properly, please refer the Swagger validation checker errors, and apiProperties.json file cannot be picked by validator. Please recommit or close this PR and open a new PR. Please don't merge it until the review is completed.

Hello @vmanoharas,

Thank you for the feedback. I have checked the Swagger validator on my side with paconn and it only returns warnings, no errors. Could you please provide more details on the issues ?

Thank you for your assistance.

@vmanoharas
Copy link
Contributor

Hello @Sylvain-Chu,

Thank you for validating again, however you have merged the branch before the review, kindly recommit the PR and don't merge it until the review.

image

Copy link
Contributor

You are not allowed to delete the mandatory files in this repo.

Total execution time: 3.01 seconds

@Sylvain-Chu
Copy link
Contributor Author

A new pull request has been created to address the issues in this one. Please refer to #3509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants