New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ubiqod by Skiply v2 connector #3417
Conversation
@microsoft-github-policy-service agree company="Skiply" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Sylvain-Chu
Your merge commit has an issue, it has not merged properly, please refer the Swagger validation checker errors, and apiProperties.json file cannot be picked by validator. Please recommit or close this PR and open a new PR. Please don't merge it until the review is completed.
certified-connectors/Ubiqod by Skiply (v2)/apiDefinition.swagger.json
Outdated
Show resolved
Hide resolved
Hello @Sylvain-Chu Your merge commit has an issue, it has not merged properly, please refer the Swagger validation checker errors, and apiProperties.json file cannot be picked by validator. Please recommit or close this PR and open a new PR. Please don't merge it until the review is completed. |
Hello @vmanoharas, Thank you for the feedback. I have checked the Swagger validator on my side with paconn and it only returns warnings, no errors. Could you please provide more details on the issues ? Thank you for your assistance. |
Hello @Sylvain-Chu, Thank you for validating again, however you have merged the branch before the review, kindly recommit the PR and don't merge it until the review. |
A new pull request has been created to address the issues in this one. Please refer to #3509 |
When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.
apiDefinition.swagger.json
, by runningpaconn validate
command.apiProperties.json
has a valid brand color and doesn't use an invalid brand color,#007ee5
or#ffffff
. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.This pull request adds a new Ubiqod By Skiply v2 connector. With version 1 being deprecated, we are creating another one with a brand new API and lots of new features.