Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made bounds control more overridable #11819

Closed
wants to merge 1 commit into from
Closed

Made bounds control more overridable #11819

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions com.microsoft.mrtk.spatialmanipulation/BoundsControl/BoundsControl.cs
View file
Open in desktop
Expand Up @@ -530,7 +530,7 @@ private void Awake()
}
}

private void Update()
public virtual void Update()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest to make these protected virtual so we aren't allowing outside classes to call them manually

{
// If we need to recompute bounds (usually because we found a
// UGUI element), make sure we've waited enough frames since
Expand Down Expand Up @@ -672,7 +672,7 @@ private bool ComputeBounds(bool isSecondPass = false)
/// Called by <see cref="BoundsHandleInteractable"/> from its OnSelectExited.
/// Routes the XRI event data through, as well as a reference to itself, the selected handle.
/// </summary>
internal void OnHandleSelectExited(BoundsHandleInteractable handle, SelectExitEventArgs args)
public virtual void OnHandleSelectExited(BoundsHandleInteractable handle, SelectExitEventArgs args)
{
if (currentHandle == handle)
{
Expand All @@ -687,7 +687,7 @@ internal void OnHandleSelectExited(BoundsHandleInteractable handle, SelectExitEv
/// Called by <see cref="BoundsHandleInteractable"/> from its OnSelectEntered.
/// Routes the XRI event data through, as well as a reference to itself, the selected handle.
/// </summary>
internal void OnHandleSelectEntered(BoundsHandleInteractable handle, SelectEnterEventArgs args)
public virtual void OnHandleSelectEntered(BoundsHandleInteractable handle, SelectEnterEventArgs args)
{
if (currentHandle != null)
{
Expand Down Expand Up @@ -734,7 +734,7 @@ internal void OnHandleSelectEntered(BoundsHandleInteractable handle, SelectEnter
private static readonly ProfilerMarker TransformTargetPerfMarker =
new ProfilerMarker("[MRTK] BoundsControl.TransformTarget");

private void TransformTarget()
public virtual void TransformTarget()
{
using (TransformTargetPerfMarker.Auto())
{
Expand Down