User/brandon palmer/auto migrate shaders

[palmerdesigns]

Overview

When Converting Lit Shader to Graphics Tools, it will Retain Changes

Changes

• Assigned Universal Render Pipeline/Lit to Old Shader
• Assigned Normal Map - Lit Shader
• Assigned Emission Map - Lit Shader
• Assigned Smoothness - Lit Shader
• Assigned Tiling & Offset - Lit Shader
• Assigned Metallic - Lit Shader

[Cameron-Micka]

This is already a huge improvement, well done! Added a few comments inline. One other request is could you add support for these properties?

The surface type is a bit complex, but that logic occurs here:

MixedReality-GraphicsTools-Unity/com.microsoft.mrtk.graphicstools.unity/Editor/ShaderGUIs/StandardShaderGUI.cs

Line 549 in cd755a0

// Setup the rendering mode based on the old shader.

[Cameron-Micka]

Could you also add support for these URP shaders?

They likely use similar property names so it might be as easy as checking:
oldShader.name.Contains("Universal Render Pipeline/Lit") || oldShader.name.Contains("Universal Render Pipeline/Simple Lit") || etc...

then adding any missing properties.

[Cameron-Micka]

Just a suggestion, I wonder if you could collapse all this into one conditionally so the body was the same. For example:

if (oldShader.name.Contains("Universal Render Pipeline/Lit") || oldShader.name.Contains("Universal Render Pipeline/Simple Lit") || etc... )
{
    normalMap = material.IsKeywordEnabled("_NORMALMAP") ? 1.0f : 0.0f;
    emission = material.IsKeywordEnabled("_EMISSION") ? 1.0f : 0.0f;
    reflections = GetFloatProperty(material, "_EnvironmentReflections");
    specularHighlights = GetFloatProperty(material, "_SpecularHighlights");
    smoothness = GetFloatProperty(material, "_Smoothness");
    textureScaleOffset = GetVectorProperty(material, "_TextureScaleOffset");
    metallic = GetFloatProperty(material, "_Metallic");
    alphaClip = GetFloatProperty(material, "_AlphaClip");
}

[Cameron-Micka]

Could you also handle the opaque vs transparent render mode?