Fix/teams compliance recording policy #3754
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykuijs
requested changes
Nov 10, 2023
...SC/DSCResources/MSFT_TeamsComplianceRecordingPolicy/MSFT_TeamsComplianceRecordingPolicy.psm1
Outdated
Show resolved
Hide resolved
|
@sandrola Thanks for your PR and the work you put into it! Any chance you could resolve conflicts and address Yorick's comments? |
|
As the original issue #3754 has been closed, I think this PR should be close |
andikrueger
reviewed
Nov 17, 2023
andikrueger
reviewed
Nov 17, 2023
CHANGELOG.md
Outdated
| @@ -14,6 +14,8 @@ | |||
| * MISC | |||
| * M365DSCReport: Also define property dataType, if present, as being primary key on | |||
| CIM instances. | |||
| * TeamsComplianceREcordingPolicy | |||
| [ClassVersion("1.0.0.0"), FriendlyName("TeamsComplianceRecordingPolicy")] | ||
| class MSFT_TeamsComplianceRecordingPolicy : OMI_BaseResource | ||
| { | ||
| [Key, Description("Unique identifier of the application instance of a policy-based recording application to be retrieved.")] String Identity; | ||
| [Write, Description("A list of application instances of policy-based recording applications to assign to this policy. The Id of each of these application instances must be the ObjectId of the application instance as obtained by the Get-CsOnlineApplicationInstance cmdlet.")] String ComplianceRecordingApplications[]; | ||
| [Write, Description("A list of application instances of policy-based recording applications to assign to this policy. The Id of each of these application instances must be the ObjectId of the application instance as obtained by the Get-CsOnlineApplicationInstance cmdlet."), EmbeddedInstance("MSFT_TeamsComplianceRecordingApplication")] String ComplianceRecordingApplications[]; |
There was a problem hiding this comment.
Would we classify this as a breaking change @NikCharlebois
There was a problem hiding this comment.
Yes, changing a param type is a breaking change unfortunately.
NikCharlebois
approved these changes
Mar 18, 2024
CHANGELOG.md
Outdated
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| # UNRELEASED | |||
|
|
|||
| * TeamsComplianceREcordingPolicy | |||
There was a problem hiding this comment.
Picky, but typo in the name, please use lower case 'e'
| [ClassVersion("1.0.0.0"), FriendlyName("TeamsComplianceRecordingPolicy")] | ||
| class MSFT_TeamsComplianceRecordingPolicy : OMI_BaseResource | ||
| { | ||
| [Key, Description("Unique identifier of the application instance of a policy-based recording application to be retrieved.")] String Identity; | ||
| [Write, Description("A list of application instances of policy-based recording applications to assign to this policy. The Id of each of these application instances must be the ObjectId of the application instance as obtained by the Get-CsOnlineApplicationInstance cmdlet.")] String ComplianceRecordingApplications[]; | ||
| [Write, Description("A list of application instances of policy-based recording applications to assign to this policy. The Id of each of these application instances must be the ObjectId of the application instance as obtained by the Get-CsOnlineApplicationInstance cmdlet."), EmbeddedInstance("MSFT_TeamsComplianceRecordingApplication")] String ComplianceRecordingApplications[]; |
There was a problem hiding this comment.
Yes, changing a param type is a breaking change unfortunately.
|
Can we please merge and update the PR with the latest changes? Thanks |
|
There are still some conflicts with the Dev branch that need to get resolved before we can merge this PR. Could you have another look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Add CIM Instance to MSFT_TeamsComplianceRecordingPolicy to be able to compare with configured policy
This Pull Request (PR) fixes the following issues