Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logistic regression solution notebook refactoring #645

Merged
merged 2 commits into from Apr 13, 2023

Conversation

carlotta94c
Copy link
Collaborator

  • Fixing features encoding (using ordinal encoder for Item size, categorical encoder for all the other features and label encoder for Color) as recommended by scikit-learn documentation
  • Using F1 score instead of accuracy to evaluate the model since the dataset is highly skewed
  • Updating plots to better show the data before and after encofings and the relationships between label and features
  • Fixing ROC curve plot using matplotlib

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://gray-sand-07a10f403-645.westeurope.1.azurestaticapps.net

@bstollnitz
Copy link

Looks great!

@bstollnitz bstollnitz marked this pull request as ready for review March 7, 2023 23:04
@carlotta94c carlotta94c added the quality_review Quality review PRs performed by repo owners label Mar 8, 2023
@jimbobbennett
Copy link
Contributor

Should we remove the output from this notebook? Would make it smaller and easier to diff

@gdequeiroz
Copy link

Should we remove the output from this notebook? Would make it smaller and easier to diff

@jimbobbennett
Do you mean just for the PR or in general? Since this is a solution notebook, we would like to have the output (+ we are trying to be consistent with the other solution notebooks from the other sections.

@jimbobbennett
Copy link
Contributor

Should we remove the output from this notebook? Would make it smaller and easier to diff

@jimbobbennett Do you mean just for the PR or in general? Since this is a solution notebook, we would like to have the output (+ we are trying to be consistent with the other solution notebooks from the other sections.

I was thinking in general, just this notebook was in the PR so made me think of it. Is it intentional to have the output in the notebooks then?

@gdequeiroz
Copy link

Should we remove the output from this notebook? Would make it smaller and easier to diff

@jimbobbennett Do you mean just for the PR or in general? Since this is a solution notebook, we would like to have the output (+ we are trying to be consistent with the other solution notebooks from the other sections.

I was thinking in general, just this notebook was in the PR so made me think of it. Is it intentional to have the output in the notebooks then?

Yes! :)

@jimbobbennett
Copy link
Contributor

Can't add this inline as the file is too large, but in the Build your model section, this line:

from sklearn.model_selection import train_test_split

is in both of the first 2 cells, it doesn't need to be in the second one.

image

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://gray-sand-07a10f403-645.westeurope.1.azurestaticapps.net

@carlotta94c carlotta94c merged commit ecd4469 into main Apr 13, 2023
3 checks passed
@carlotta94c carlotta94c deleted the ml_for_beginners_review branch April 13, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality_review Quality review PRs performed by repo owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants