Fix path returned for FHIR to HL7v2 default template errors #545
Conversation
| : base(processorSettings, logger) | ||
| { | ||
| } | ||
|
|
||
| protected override DataType DataType { get; set; } = DataType.Fhir; |
There was a problem hiding this comment.
I don't think this would work as is. The value in DataType is used as the base folder within which we extract and search the default templates, and currently, DataType.Fhir is also used for FhirProcessor (STU3), so this will conflict.
There was a problem hiding this comment.
I think when you add the default template for Fhir to Hl7v2, you will run into this. It might end up extracting both STU3 and the new templates you'll be adding into the same folder named 'Fhir', and cause issues on template lookups.
There was a problem hiding this comment.
that is a good point. This PR technically returns the correct error, but yeah I see how the DataType is used in in both the STU3 and the FhirToHl7v2 scenarios and would result in templates sharing the same path which is not ideal. I went ahead and separated the two into different paths using a new Enum called DefaultRootTemplateParentPath so that the input DataType is no longer used to determine the path. The changes for FHIR to HL7v2 default templates are being made as part of this larger PR: https://github.com/microsoft/FHIR-Converter/pull/557/files#diff-9e9af2fb4a114d2641a7b5b0caab08401bdcafbf10e5957321817235d8361d03 so I am going to abandon this PR since the changes are included in the other PR
Previously when a default template did not exist the code was returning the default path of "Hl7v2/" when converting from FHIR to HL7v2. The path should be "Fhir/" so the PR updates the path that is returned.