Debump markdown-it and emit PrecompiledGlobalize.js #5181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
PrecompiledGlobalize.js
is emitted instead of.cjs
, by @compulim in PR #5181Changed
markdown-it@14.1.0
Description
We should not emit
.cjs
as it is not understood by Webpack 4.Also, recent bump of
markdown-it@14
revealed a problem with theirmodule
field.Specific Changes
markdown-it@13
/src/external/PrecompiledGlobalize.js
and transpile it by babel/tsup/lib/external/PrecompiledGlobalize.js
should have__esModule
markerPrecompiledGlobalize.js
I have added tests and executed them locallyCHANGELOG.md
I have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)