Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base package #5176

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add base package #5176

wants to merge 6 commits into from

Conversation

OEvgeny
Copy link
Collaborator

@OEvgeny OEvgeny commented May 8, 2024

Fixes #

Changelog Entry

(No changelog entry for the change)

Description

Add a stub botframework-webchat-base package. In case we need something extremely useful to be shared across our packages, it'll help.

Design

Specific Changes

-

  • Added base package
  • Added build infra
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@OEvgeny OEvgeny marked this pull request as ready for review May 8, 2024 18:57
packages/README.md Outdated Show resolved Hide resolved
packages/base/babel.config.json Outdated Show resolved Hide resolved
OEvgeny and others added 4 commits May 8, 2024 22:10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also mark this package as private: true so we don't accidentally publish it.

@compulim compulim mentioned this pull request May 9, 2024
35 tasks
@compulim
Copy link
Contributor

compulim commented May 9, 2024

Let's make this base package internal and bundled into other packages.

For a cleaner approach, we should use tsup for CJS build and no longer need Babel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants