New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix src/k4a_ros_device.cpp rclcpp::Duration(double) #275

Open

soeroesg wants to merge 1 commit into microsoft:humble from soeroesg:humble

soeroesg commented Sep 13, 2023 •

edited

Fixes

Fixes #270

fix src/k4a_ros_device.cpp rclcpp::Duration(double)

Description of the changes:

rclcpp::Duration(double) does not exist in ROS humble, instead we can use rclcpp::Duration::from_seconds())

Required before submitting a Pull Request:

I reviewed CONTRIBUTING.md
I built my changes locally
I tested my changes with a device
I changed both the ROS1 and ROS2 branches (the change only applies to ROS2)

I tested changes on:

Windows (I have no ROS on Windows but the change is minimal)
Linux
ROS1 (no change needed)
ROS2


          fix src/k4a_ros_device.cpp rclcpp::Duration(double)

dba573b

rclcpp::Duration(double) does not exist in ROS humble

Thaina commented Mar 29, 2024 •

edited

Same here on kinect k4a sample for unity. Can it be used the same fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment