Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding depth and registration evaluation tools to examples directory #1477

Open
wants to merge 42 commits into
base: develop
Choose a base branch
from

Conversation

resuther-msft
Copy link

@resuther-msft resuther-msft commented Jan 15, 2021

Fixes

Description of the changes:

  • Adding C++ code that leverages OpenCV to evaluate the depth calibration of k4a devices (depth_eval_tools/depth_eval).
  • Adding C++ code that leverages OpenCV to evaluate the registration between the sensors of a k4a device (depth_eval_tools/transformation_eval).
  • Adding C++ code that leverages OpenCV to collect and process images from a k4a device for the aforementioned tools and new Calibration and Registration tools added in another pull request (depth_eval_tools/collect).
  • Ading C++ code that leverages OpenCV to process mkv captures for the aforementioned tools and dump images from a capture (depth_eval_tools/mkv2images).
  • Adding C++ helper code that leverages OpenCV and is used by the aforementioned tools (depth_eval_tools/kahelpers).
  • Adding an overview README.md to describe how to use the tools, and individual README.md files with more details for each tool.
  • Adding CMakeLists.txt files for examples/depth_eval_tool directory and for each aforementioned tool.
  • Modifying CMakeLists.txt file in examples directory to include depth_eval_tools directory.
  • Repo fails to build using "x86_64 Native Tools Command Prompt for VS 2017" (both with new additions as well as without) but builds successfully using "x64 Native Tools Command Prompt for VS 2019". Build issues seem to be related to opencv module architecture differing from target architecture.

Before submitting a Pull Request:

I tested changes on:

  • Windows
  • Linux

Copy link
Contributor

@JonathanESantos JonathanESantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions, no major errors found.

examples/depth_eval_tools/README.md Show resolved Hide resolved
examples/depth_eval_tools/README.md Outdated Show resolved Hide resolved
examples/depth_eval_tools/README.md Show resolved Hide resolved
examples/depth_eval_tools/README.md Show resolved Hide resolved
examples/depth_eval_tools/collect/README.md Outdated Show resolved Hide resolved
examples/depth_eval_tools/transformation_eval/README.md Outdated Show resolved Hide resolved
@jaygullapalli
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants