Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 'Redirecto to wrong URL #187' #190

Closed
wants to merge 28 commits into from

Conversation

MichaelHumplEnBW
Copy link

The "Location"-HTTP-Header don't need to be URL-Decoded

@MichaelHumplEnBW
Copy link
Author

MichaelHumplEnBW commented Oct 7, 2020

I'am very sorry, i work on a solution for the Issue "[Feature Request] Url Resolution Landing Page #189" and do not use a extra branch for this. Now i down know how to sparate the changes.

@Miboch
Copy link

Miboch commented Oct 9, 2020

I'm a little worried about the automatic redirect. While its nice to save a click I can easily imagine edge cases where users get distracted, or minimize the page on their mobile devices, forgetting about it before coming back later.

Personally I would prefer a "Continue" button, but this is so much better than not having the feature at all! 👍

@MichaelHumplEnBW
Copy link
Author

MichaelHumplEnBW commented Oct 9, 2020

No Problem, the newest version has now auto-redirect.

@MichaelHumplEnBW
Copy link
Author

Now the html-layout is improved and there is a Submit-Button :-)

@FBoucher FBoucher added feature feature-request frontend hacktoberfest-accepted This PR is lovely and accepted for Hacktoberfest labels Oct 10, 2020
@FBoucher FBoucher added this to To Do in Azure Url Shortener Dec 29, 2020
@FBoucher FBoucher linked an issue Dec 29, 2020 that may be closed by this pull request
@FBoucher FBoucher changed the base branch from main to vnext December 29, 2020 19:50
@FBoucher FBoucher linked an issue Dec 29, 2020 that may be closed by this pull request
@FBoucher
Copy link
Collaborator

Great Code @MichaelHumplEnBW
Would you consider updating your code to be more consistent with the other API methods?

The Redirect function is for redirecting a call. It's important that the URLS pass through this one for statistics.

Generating a QRCode could be done in a function named UrlQRCodeCreate or something like that.

@FBoucher FBoucher deleted the branch microsoft:vnext November 25, 2022 18:33
@FBoucher FBoucher closed this Nov 25, 2022
@FBoucher FBoucher removed this from To Do in Azure Url Shortener Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature-request frontend hacktoberfest-accepted This PR is lovely and accepted for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirecto to wrong URL Feature request (idea): Create QR Code for ShortUrl
3 participants