Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement IDynamicLinksService.getDynamicLink() for compatibility with react native firebase email link auth #2297

Merged
merged 2 commits into from Apr 29, 2024

Conversation

derMart
Copy link
Contributor

@derMart derMart commented Apr 5, 2024

Currently the implementation of getInitialLink just returns null to the client which breaks the authentication method of react native firebase using an email link only.
In their documentation there is no example code for this, but some apps implement authentication like this:
https://stackoverflow.com/questions/61564203/how-to-setup-sendsigninlinktoemail-from-firebase-in-react-native relying on the payload data of the dynamic links service.

This pull request implements

public void getInitialLink(IDynamicLinksCallbacks callback, String link) throws RemoteException {
callback.onStatusDynamicLinkData(Status.SUCCESS, null);
}

by parsing the link and returning the correct payload to the client. There are a few security related checks if the package name of the link does not match the receiving package name or if it is missing. I was able to get some logins to work. It might also fix #1547 as this is related to the dynamic links service, but I haven't tested apps reported there.

best :-)

@mar-v-in mar-v-in added this to the 0.3.2 milestone Apr 29, 2024
@mar-v-in mar-v-in changed the title Implement IDynamicLinksService -> getInitialLink for compatibility with react native firebase email link auth Implement IDynamicLinksService.getDynamicLink() for compatibility with react native firebase email link auth Apr 29, 2024
@mar-v-in mar-v-in merged commit ca833fe into microg:master Apr 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[com.tellm.android.app] Cannot login via mail (Firebase Dynamic Links?) to Jodel etc.
2 participants