Games: Improve login auth scope logic #2273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mar-v-in
reviewed
Apr 30, 2024
...-services-base/src/main/java/com/google/android/gms/auth/api/signin/GoogleSignInOptions.java
Outdated
Show resolved
Hide resolved
play-services-core/src/main/kotlin/org/microg/gms/games/GamesSignInActivity.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the test of PUBG, it was found that the Scopes requested by the application were inconsistent with the actual request, resulting in the failure to authorize the login successfully.
And during this process, it was discovered that during the switching between horizontal and vertical screens, there would be multiple login pages, causing authorization failure.