Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using FIDO2 authenticators with a PIN #2194

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Allow using FIDO2 authenticators with a PIN #2194

wants to merge 7 commits into from

Commits on Feb 27, 2024

  1. Added rudimentary support for PIN verification for FIDO2

    @TheMartinizer
    TheMartinizer committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    430007f View commit details
    Browse the repository at this point in the history

  2. Added handling of Wrong PIN. Fixed a bug where pinHashEnc could be to… 

    …o long
    @TheMartinizer
    TheMartinizer committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    b90c54b View commit details
    Browse the repository at this point in the history

  3. Don't ask for PIN codes when unecessary. Handle PIN required exceptio… 

    …n from authenticator
    @TheMartinizer
    TheMartinizer committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    7cf4234 View commit details
    Browse the repository at this point in the history

  4. If no signOptions are provided, we should default to asking for PIN, … 

    …since this is the safest option. Firefox doesn't seem to pass on either SignOptions or RegisterOptions properly
    @TheMartinizer
    TheMartinizer committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    151ff2e View commit details
    Browse the repository at this point in the history

  5. Took some clarification regarding the uv flag from drafts of CTAP2.1 … 

    …into account
    @TheMartinizer
    TheMartinizer committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    16cf4eb View commit details
    Browse the repository at this point in the history

  6. Use only CTAP2 for registration when strictly necessary. Use named va… 

    …riables for PIN subcommands
    @TheMartinizer
    TheMartinizer committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    ff53f50 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Use the methods in the CtapConnection class to find out its capabilit… 

    …ies, instead of explicitly calculating them
    @TheMartinizer
    TheMartinizer committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    295bc67 View commit details
    Browse the repository at this point in the history