Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provisioning: Location providers #1998

Merged

Conversation

t-m-w
Copy link
Contributor

@t-m-w t-m-w commented Jul 31, 2023

New provisioning extras to control Location features:

  • Internet lookups (Mozilla Location Services): wifi_mls, cell_mls
  • Local location learning: wifi_learning, cell_learning
  • Query location from supported hotspots: wifi_moving
  • Geocoder (Nominatim): nominatim_enabled

@mar-v-in
Copy link
Member

mar-v-in commented Aug 1, 2023

This looks reasonable. Note though that (starting next version) all providers will be disabled by default (except when the corresponding UnifiedNlp module was enabled before the upgrade - having them enabled by default was actually by accident), so this will be more useful as an opt-in ;)

@t-m-w t-m-w force-pushed the provisioning-internet-location-setting branch from 6e64fab to 20841cb Compare August 1, 2023 21:04
@t-m-w
Copy link
Contributor Author

t-m-w commented Aug 1, 2023

This looks reasonable. Note though that (starting next version) all providers will be disabled by default (except when the corresponding UnifiedNlp module was enabled before the upgrade - having them enabled by default was actually by accident), so this will be more useful as an opt-in ;)

Good to know, and thanks for checking this out so quickly. I was asked to make it more granular, so I just did that now.

New provisioning extras to control Location features:
* Internet lookups (Mozilla Location Services): wifi_mls, cell_mls
* Local location learning: wifi_learning, cell_learning
* Query location from supported hotspots: wifi_moving
* Geocoder (Nominatim): nominatim_enabled

Change-Id: I334c4f92437257dac261cbc9644641df9a9eaf55
@t-m-w t-m-w force-pushed the provisioning-internet-location-setting branch from 20841cb to f3bb86d Compare August 2, 2023 20:26
@t-m-w t-m-w changed the title Provisioning: Internet-based location providers Provisioning: Location providers Aug 2, 2023
@t-m-w
Copy link
Contributor Author

t-m-w commented Aug 2, 2023

I see again what you mean about location settings being off by default, including location learning! So I added a few more settings to this, since I think users will commonly want location learning enabled.

@mar-v-in
Copy link
Member

mar-v-in commented Aug 2, 2023

In case anyone wonders why location learning is disabled by default: it effectively creates a local database of locations where the smartphone used GPS over the last weeks. For some people that may be problematic, so that's why it makes sense to be opt-in, so they're not surprised by that.

@mar-v-in mar-v-in merged commit 9be1538 into microg:master Aug 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants