Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialization regression fixes #1978

Merged
merged 2 commits into from
Jul 8, 2023
Merged

Initialization regression fixes #1978

merged 2 commits into from
Jul 8, 2023

Conversation

fynngodau
Copy link
Contributor

fynngodau and others added 2 commits July 8, 2023 19:10
@fynngodau
Run user callbacks after onCreate
1d2ae42
@jonathanklee @fynngodau
Make sure no callbacks are called when GoogleMap is destroyed
7c58c6b 
We faced an IllegalStateException related to a null root view of
a fragment layout.

If the GoogleMap is destroyed, there is no need to call the callbacks
related to it in an upcoming future.
@ale5000-git ale5000-git requested a review from mar-v-in July 8, 2023 19:29
@mar-v-in mar-v-in merged commit 99d5e09 into microg:master Jul 8, 2023
1 check passed
@fynngodau fynngodau deleted the sync-e branch July 8, 2023 19:33
@ale5000-git ale5000-git removed the request for review from mar-v-in July 9, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fynngodau @mar-v-in @jonathanklee