Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GoogleMap.OnMapLoadedCallback correctly #1960

Closed
fynngodau opened this issue Jun 17, 2023 · 0 comments · Fixed by #2182
Closed

Implement GoogleMap.OnMapLoadedCallback correctly #1960

fynngodau opened this issue Jun 17, 2023 · 0 comments · Fixed by #2182

Comments

@fynngodau
Copy link
Contributor

fynngodau commented Jun 17, 2023

GoogleMap.OnMapLoadedCallback is called as soon as the style is loaded in GoogleMap.setOnMapLoadedCallback. Per docs, it should only be called once rendering is entirely finished:

Sets a callback that's invoked when this map has finished rendering. The callback will only be invoked once.

If this method is called when the map is fully rendered, the callback will be invoked immediately. This event will not fire if the map never loads due to connectivity issues, or if the map is continuously changing and never completes loading due to the user constantly interacting with the map.

This is unfortunately not trivial to implement. Causes signalapp/Signal-Android#12723 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant