Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to share location on Android #12723

Closed
GitPudding opened this issue Jan 12, 2023 · 13 comments
Closed

Unable to share location on Android #12723

GitPudding opened this issue Jan 12, 2023 · 13 comments
Labels

Comments

@GitPudding
Copy link

Pixel 5
Android 13
CalyxOS 4.5.0
Signal 6.7.6

When trying to share my location, I am unable to send my location. Tapping the share location option will open the map screen, with the option to move the marker around, and a bar at the bottom of the screen with a checkmark and a loading wheel that continuously spins, but never does anything. When the checkmark is tapped, it will put a draft map location in the chat window, but there is no option to send it.

I don't have Google maps, and use OsmAnd~ for maps.

@greyson-signal
Copy link
Contributor

I've heard of people with similar setups having issues. A log would help me confirm it's the same issue, but the last time I saw a log related to this, the map implementation was throwing an exception when it shouldn't be, i.e. some bug in your device's implementation. If you provide a log, I'm happy to confirm.

@bme13
Copy link

bme13 commented Jan 19, 2023

This seems similar to #9101. Based on your logfile you're also using microg and I see the next messages:

  • GmsMap : unimplemented Method: setBuildingsEnabled
  • GmsMap : unimplemented Method: snapshot

Not the same as the 'GmsMap : unimplemented Method: setOnMapLoadedCallback' mentioned in the original ticket but I assume using microg is the reason.

@cody-signal
Copy link
Contributor

This looks like a bug with the address geocoder that gets into a fail loop and never resolves. We are unlikely to prioritize fixing this as it's a bit niche but if someone wants to make a PR, I'll happily review it.

@GitPudding
Copy link
Author

Thanks for looking into this everyone. I appreciate the help!

@bme13
Copy link

bme13 commented Feb 2, 2023

Looking into this it seems the address returned in the PlacePickerActivity is correct. The problem likely is the missing snapshot method in microg, used in SignalMapView. I assume that's needed to know the map is rendered correctly. It appears to be on the list at microg. See microg/GmsCore#1617

@stale
Copy link

stale bot commented Apr 3, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 3, 2023
@t-m-w
Copy link

t-m-w commented Apr 4, 2023

Don't close. Still impacts Signal 6.15.3.

@stale stale bot removed the wontfix label Apr 4, 2023
@stale
Copy link

stale bot commented Jun 8, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 8, 2023
@t-m-w
Copy link

t-m-w commented Jun 8, 2023

Don't close. Still impacts Signal 6.21.3. Thanks.

@fynngodau
Copy link
Contributor

fynngodau commented Jun 17, 2023

Even with snapshots now being implemented in microG (microg/GmsCore#1617 (comment)), the correct map is still not shared. The reason is that microG does not implement GoogleMap.OnMapLoadedCallback correctly (microg/GmsCore#1960). See also: #13006.

@stale
Copy link

stale bot commented Sep 10, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 10, 2023
@stale
Copy link

stale bot commented Sep 20, 2023

This issue has been closed due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

6 participants