Offers mockup #16
Merged
Offers mockup #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalmikolajczyk
requested changes
Mar 7, 2017
| padding-right: 137px; | ||
| margin-right: 100px; | ||
| height: 420px; | ||
| background-size: cover; |
There was a problem hiding this comment.
It's convenient way to keep images with different dimensions in the same frame (I assume that pictures from users have different sizes)
There was a problem hiding this comment.
yep, but do we use it as backgrounds? Is that better then <img>?
src/ts/Container/index.tsx
Outdated
| @@ -5,10 +5,11 @@ import Footer from '../Footer'; | |||
| import Header from '../Header'; | |||
|
|
|||
| export default function Container(props) { | |||
| const header = props.close ? null : <Header />; | |||
There was a problem hiding this comment.
const header = props.close && <Header />;
src/ts/Detail/Comments.tsx
Outdated
| import * as _ from 'lodash'; | ||
|
|
||
| export default function Comments(props) { | ||
| const stars = () => _.times(5, i => <FontIcon key={i} className="fa fa-star"/>); |
There was a problem hiding this comment.
why not a value?
const stars = _.times(5, i => <FontIcon key={i} className="fa fa-star"/>);
| <div className="text"> | ||
| Aba. By that I mean a comment which is actually quite in-depth, but I can't really | ||
| <br/> | ||
| articulate it well just yet, because I am only two years old. |
There was a problem hiding this comment.
😂
(laughing at my own jokes)
src/ts/Detail/Comments.tsx
Outdated
| </div> | ||
| </div> | ||
| <div className="view-all"> | ||
| View all references |
There was a problem hiding this comment.
<div className="view-all">
<a href>View all references</a>
</div>
| @@ -0,0 +1,155 @@ | |||
| const ktm = { | |||
src/ts/Offers/Offer.tsx
Outdated
| approx, | ||
| } = props.data; | ||
| const img = props.data.images.main; |
There was a problem hiding this comment.
how can we be sure that those props exist?
perhaps _.get(props, 'data.images.main') would be safer?
| @@ -19,7 +19,7 @@ export default function OffersList(props) { | |||
| </button> | |||
| ); | |||
|
|
|||
| const mappedItems = data.map(item => <Offer data={item} key={item.key} />); | |||
| const mappedItems = data.map(item => <Offer data={item} key={item.url} />); | |||
| @@ -8,7 +8,7 @@ describe('<Router />', () => { | |||
| it('check for all paths', () => { | |||
| const paths = [ | |||
| '/', | |||
| '/detail', | |||
| '/offer/:offer', | |||
| @@ -18,7 +18,7 @@ export default function AppRouter(props) { | |||
| return ( | |||
| <Router history={browserHistory}> | |||
| <Route path="/" component={Offers} /> | |||
| <Route path="/detail" component={Detail} /> | |||
| <Route path="/offer/:offer" component={Detail} /> | |||
michalmikolajczyk
approved these changes
Mar 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created offers list & offers details with hardcoded data.