Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#130 AsyncIterator.return() #131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#130 AsyncIterator.return() #131

wants to merge 1 commit into from

Conversation

timoshisa
Copy link

@timoshisa timoshisa commented Jan 18, 2021 •
edited

In relation to issue #130 enable AsyncIterator.return() on client disconnect by passing back ISubscriber[] from unsubscribeAllByConnectionId and in turn connectionManager.unregisterConnection.

@michalkvasnicak michalkvasnicak self-requested a review March 14, 2021 13:24
michalkvasnicak
michalkvasnicak requested changes Mar 14, 2021
View reviewed changes
Copy link
Owner

@michalkvasnicak michalkvasnicak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tbehrsin could you please:

  • add some tests
  • rebase and provide the same functionality for new DynamoDBRangeSubscriptionManager
    ?

Also if client unsubscribes from some subscription (GQL_STOP event) shouldn't we call return() too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkvasnicak michalkvasnicak michalkvasnicak requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timoshisa @michalkvasnicak