Add Windows support (RNW 0.64.0) #146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
April 12, 2021 12:50
This was referenced Apr 14, 2021
|
UPDATE: |
|
Hey! Thank you for this contribution. I'm definitely interested in adding windows support as a part of the next major release. |
|
unfortunately, i have moved on from the project i needed this for. but there’s anything you need from me to move this along for the community, just ask. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#145
Overview
Add Windows support targeting React Native Windows 0.64.0. I don't claim to be a C++ expert, so am open for any and all feedback. I am opening this PR to hopefully start receiving any feedback early.
Test Plan
I am still testing on my laptop in dev, but intend to test on a Surface Pro and Honeywell tablets with cellular cards under a Release build when I return home early next week, and adding unit tests wherever possible in the meantime.