Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same SR frequencies per group #1469

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

severgun
Copy link
Contributor

@severgun severgun commented Jun 19, 2019

When merged this pull request will:

There is quite big chance of collisions so may be it is necessary to add uniqueness test for first element in array, or instead of TFAR_FREQ_ROUND_POWER value should be set to 100.

@dedmen
Copy link
Collaborator

dedmen commented Jun 19, 2019

or instead of TFAR_FREQ_ROUND_POWER value should be set to 100

Would be a compatibility breaker.

I don't care much about uniqeness, we already don't care for the "same frequencies per side" feature.

@dedmen
Copy link
Collaborator

dedmen commented Jun 19, 2019

Fixes #1468

@dedmen dedmen force-pushed the master branch 2 times, most recently from 95fc297 to 53edae8 Compare October 3, 2019 10:23
@dedmen
Copy link
Collaborator

dedmen commented Oct 3, 2019

I like this and this also works fine.
But this only runs on serverInit, which runs once.
If any player JIPs and while doing that creates a new group, this won't execute on his group.
We'd need some kind of playerJoined/groupCreated eventhandler, to run this then.

@severgun
Copy link
Contributor Author

Added event. Will it work now?

@dedmen
Copy link
Collaborator

dedmen commented Oct 14, 2019

I don't like the 0 delay PFH, but if there is no better alternative.. Then I guess it has to be.

@severgun
Copy link
Contributor Author

There is no native BIS EH for group creation. So I think that is only one option.
Delay can be increased but then there can be collisions when some groups deleted and some created during delay.

@dedmen
Copy link
Collaborator

dedmen commented Apr 15, 2022

There is no native BIS EH for group creation.

https://community.bistudio.com/wiki/Arma_3:_Mission_Event_Handlers#GroupCreated
https://community.bistudio.com/wiki/Arma_3:_Mission_Event_Handlers#GroupDeleted

Do you want to update the PR with it or shall I merge this now and upgrade later?

@severgun
Copy link
Contributor Author

I will take a look at this week.

@severgun
Copy link
Contributor Author

Couple questions:

  1. "GroupCreated" fires for 33 groups even if only 1 exist.
  2. Old feature "group freqs" from group attributes does not work. Seems like attribute expression called before group is fully populated and values are not broadcasted.
  3. If "same per group" and "same for side" are selected, what we should take in favor?

@dedmen
Copy link
Collaborator

dedmen commented May 27, 2023

  1. I think there is something in vanilla code that creates bogus groups. But that was fixed recently-ish in a game update.
  2. Mh maybe we can just execNextFrame
  3. Closest wins, so group

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants